After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690105 - Remove input source switching keybindings
Remove input source switching keybindings
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 690426
Blocks:
 
 
Reported: 2012-12-12 15:28 UTC by Rui Matos
Modified: 2012-12-18 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove input source switching keybindings (1.55 KB, patch)
2012-12-12 15:28 UTC, Rui Matos 		rejected Details | Review
region: Update for the input source switching keybindings move (1.66 KB, patch)
2012-12-12 15:28 UTC, Rui Matos 		needs-work Details | Review
region: Update for the input source switching keybindings move (2.23 KB, patch)
2012-12-18 16:12 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-12-12 15:28:54 UTC 
This is to go along with bug 682315.
Comment 1 Rui Matos 2012-12-12 15:28:56 UTC 
Created attachment 231382 [details] [review]
Remove input source switching keybindings

These are now provided by gnome-shell.
Comment 2 Rui Matos 2012-12-12 15:28:59 UTC 
Created attachment 231383 [details] [review]
region: Update for the input source switching keybindings move

These are now provided by gnome-shell.
Comment 3 Bastien Nocera 2012-12-17 14:58:02 UTC 
Review of attachment 231383 [details] [review]:

::: panels/region/gnome-region-panel-input.c
@@ +1151,3 @@
   GSettings *settings;
 
+  settings = g_settings_new ("org.gnome.shell.keybindings");

We can't have gnome-control-center depend on gnome-shell.

The key will have to move to gsettings-desktop-schemas.
Comment 4 Bastien Nocera 2012-12-17 14:58:31 UTC 
Review of attachment 231382 [details] [review]:

Which means that we should remove that file but update it.
Comment 5 Rui Matos 2012-12-18 16:12:33 UTC 
Created attachment 231814 [details] [review]
region: Update for the input source switching keybindings move

These are now provided by gsettings-desktop-schemas.
Comment 6 Bastien Nocera 2012-12-18 16:28:35 UTC 
Review of attachment 231814 [details] [review]:

Can you please split this into 2 patches?
And make sure to bump the gsettings-desktop-schemas dependency too.

Looks good otherwise.
Comment 7 Rui Matos 2012-12-18 16:58:00 UTC 
Pushed split in two and requiring a version bumped
gsettings-desktop-schemas.

Attachment 231814 [details] pushed as 4e3a2e1 - region: Update for the input source switching keybindings move