After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690086 - Network fixups for proper copy/paste into GIS
Network fixups for proper copy/paste into GIS
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-12 10:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-14 07:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Add a proper header guard to network-dialogs.h (1.23 KB, patch)
2012-12-12 10:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
network: Don't reference CcNetworkPanel directly from some helper code (9.80 KB, patch)
2012-12-12 10:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-12 10:05:41 UTC 
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-12 10:05:43 UTC 
Created attachment 231330 [details] [review]
network: Add a proper header guard to network-dialogs.h

We want to copy/paste this into g-i-s, so it needs to at least try
to be a decent library-ish thing.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-12 10:05:45 UTC 
Created attachment 231331 [details] [review]
network: Don't reference CcNetworkPanel directly from some helper code

All we need is the toplevel, here, so pass that in directly.
Comment 3 Bastien Nocera 2012-12-12 12:01:43 UTC 
Review of attachment 231330 [details] [review]:

Fine.
Comment 4 Bastien Nocera 2012-12-12 12:02:53 UTC 
Review of attachment 231331 [details] [review]:

Fine.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-14 07:07:52 UTC 
Attachment 231330 [details] pushed as 6b1ae0b - network: Add a proper header guard to network-dialogs.h
Attachment 231331 [details] pushed as 23e5149 - network: Don't reference CcNetworkPanel directly from some helper code