GNOME Bugzilla – Bug 690084
gmarkup: Make GMarkupParseContext a boxed type
Last modified: 2013-01-01 16:03:05 UTC
I had this in my local tree, but I forget why.
Created attachment 231327 [details] [review] gmarkup: Make GMarkupParseContext a boxed type At the same time, add a refcount and public ref/unref methods. This makes it usable from introspectable.
Is it really usable though? I don't think gjs at least has support for setting up the callbacks in the structure. Where were you using this?
In combination with #679299.
grah, bug #679299
Review of attachment 231327 [details] [review]: Also need to patch gobject/gobject.symbols. ::: glib/gmarkup.c @@ +119,3 @@ const GMarkupParser *parser; + gint ref_count; volatile, per g_atomic_int API @@ +279,3 @@ + * Returns: the same @context + * + * Since: 2.34 2.36 now @@ +299,3 @@ + * drops to 0, it is freed. + * + * Since: 2.34 2.36 now @@ +1040,3 @@ * g_markup_parse_context_parse: * @context: a #GMarkupParseContext + * @text: (array length=text_len): chunk of text to parse Per bug 688731, I don't think this should have an annotation right now. It's *not* an array.
Created attachment 231541 [details] [review] gmarkup: Make GMarkupParseContext a boxed type At the same time, add a refcount and public ref/unref methods. This makes it usable from introspectable.
Review of attachment 231541 [details] [review]: ::: glib/gmarkup.c @@ +279,3 @@ + * Returns: the same @context + * + * Since: 2.34 2.36 @@ +299,3 @@ + * drops to 0, it is freed. + * + * Since: 2.34 2.36 ::: glib/gmarkup.h @@ +184,3 @@ GDestroyNotify user_data_dnotify); +GMarkupParseContext *g_markup_parse_context_ref (GMarkupParseContext *context); +void g_markup_parse_context_unref (GMarkupParseContext *context); G_AVAILABLE_IN_2_36
Fixed up, and pushed. Attachment 231541 [details] pushed as 5e62827 - gmarkup: Make GMarkupParseContext a boxed type