After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690069 - g_unix_open_pipe: Add missing F_SETFD
g_unix_open_pipe: Add missing F_SETFD
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-12-11 21:55 UTC by Colin Walters
Modified: 2012-12-12 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
g_unix_open_pipe: Add missing F_SETFD (1.06 KB, patch)
2012-12-11 21:55 UTC, Colin Walters 		reviewed Details | Review
g_unix_open_pipe: Add missing F_SETFD (1.18 KB, patch)
2012-12-11 22:13 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-11 21:55:39 UTC 
Spotted by Ray Strode <rstrode@redhat.com>
Comment 1 Colin Walters 2012-12-11 21:55:41 UTC 
Created attachment 231309 [details] [review]
g_unix_open_pipe: Add missing F_SETFD
Comment 2 Ray Strode [halfline] 2012-12-11 22:02:25 UTC 
Review of attachment 231309 [details] [review]:

Seems right, but maybe we should avoid calling fcntl at all if flags is 0 ?
Comment 3 Colin Walters 2012-12-11 22:13:30 UTC 
Created attachment 231310 [details] [review]
g_unix_open_pipe: Add missing F_SETFD

While we're here, microoptimize by skipping the fcntl() calls if flags
is 0.
Comment 4 Matthias Clasen 2012-12-12 01:12:24 UTC 
Review of attachment 231310 [details] [review]:

sure
Comment 5 Colin Walters 2012-12-12 13:06:25 UTC 
Attachment 231310 [details] pushed as c700721 - g_unix_open_pipe: Add missing F_SETFD