GNOME Bugzilla – Bug 690062
Cleanup context menus
Last modified: 2013-12-17 15:53:06 UTC
Review and cleanup context menus: Empty space in page: ===== Back Forward Reload - Add bookmark - Send link by email - Inspect element Right click on link: ===== Open link Open link in new tab Open link in new window - Download link Save link as Add bookmark Copy link URL - Inspect element Right click on a image: ===== Back Forward Reload - Add bookmark (from page context menu) - Open image Save image as Use image as background Copy image's URL - Send link by email (from page context menu) - Inspect element Right click on linked image: ===== Open link Open link in new tab Open link in new window - Download link Save link as Add bookmark Copy link URL - Open image Save image as Use image as background Copy image's URL - Inspect element
Created attachment 231300 [details] [review] menus: cleanup EphyDocumentPopup Remove "Add Bookmark", and move "Send link by email" to the gear menu.
Created attachment 231301 [details] [review] menus: add an image specific context menu If we reuse the Document popup we get lots of irrelevant actions.
Created attachment 231302 [details] [review] menus: reorder image items in all popups Prioritize "Save image as", and "Copy image address".
Created attachment 231303 [details] [review] menus: improve Open Image label Make it Open in Image Viewer.
Created attachment 231304 [details] [review] menus: remove redundant OpenLink action Assume that users right-clicking a link, know how a link behaves when clicked.
Created attachment 231305 [details] [review] menus: remove redundant Download link action Only leave "Save link as" in the menu.
Created attachment 231376 [details] [review] menus: cleanup menus - Add an image specific context menu. If we reuse the Document popup we get lots of irrelevant actions. - Reorder image items: prioritize "Save image as", and "Copy image address". - Only show "Inspect Element" on control+right-click. - Move context menu "Send link by email" to the gear menu. - Rename "Open Image" to "Open in Image Viewer". - Remove redundant "Open Link" action. - Remove redundant "Download Link" action. - Remove "Add Bookmark" from context menu. --- After discussing with lapo, he suggested hiding InspectElement unless control+right-click is used.
Overall looks nice. A couple of comments. * In Files we use "Set as Wallpaper" to avoid confusion about what background is meant. * Perhaps we should have "Select All" in the page context menu. * Open in Image Viewer should probably say "Open in APPNAME" * The menu on page background looks a bit sad and small... dunno.
Created attachment 231399 [details] [review] Cleanup context menus - Add an image specific context menu. If we reuse the Document popup we get lots of irrelevant actions. - Reorder image items: prioritize "Save image as", and "Copy image address". - Make "Open Image", "Open with %AppName". - Only show "Inspect Element" on control+right-click. - Move context menu "Send link by email" to the gear menu. - Rename "Set Image as Background" to "Set as Wallpaper", like in Nautilus. - Remove redundant "Open Link" action. - Remove redundant "Download Link" action. - Remove "Add Bookmark" from context menu. --- This considers Jon's comments, except for SelectAll. Re: SelectAll I think it might not be so useful because of the nature of websites being not only content text but also navigation links, login names, action links, etc. All these items being text and thus making SelectAll much less useful than in a text editor or textarea (where it already is).
Created attachment 264220 [details] [review] Remove unused popup menus Removed in the port to WebKit2
Created attachment 264221 [details] [review] Cleanup context menus
*** Bug 708537 has been marked as a duplicate of this bug. ***
*** Bug 549930 has been marked as a duplicate of this bug. ***
Review of attachment 264220 [details] [review]: dead data
Review of attachment 264221 [details] [review]: I used to use download link a lot, but I guess I can live without it with the patch to automatically close tabs when they're created just for downloading. ::: src/ephy-window.c @@ +1805,3 @@ + if (!is_image) + { + add_action_to_context_menu (context_menu, This is the only bit I'm not so sure about. When an image fills the page you might still want to be able to use the contextual menu to go back. For instance, if you go to an image such as http://www.nyewall.com/images/2013/08/tiger-hd-wallpapers.jpg and it's zoomed to the original size (by clicking). What do you think?
Review of attachment 264221 [details] [review]: Download link was kind of a duplicate of Save Link As. So I think we'll still have most of what you need. ::: src/ephy-window.c @@ +1805,3 @@ + if (!is_image) + { + add_action_to_context_menu (context_menu, I think we'll be fine just using the back button on the headerbar or keyboard hotkeys. This is what both Chrome and Firefox do already.
Attachment 264220 [details] pushed as 526b5c0 - Remove unused popup menus Attachment 264221 [details] pushed as 9d10f81 - Cleanup context menus