After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690050 - Improve recursive epiphany launching prevention
Improve recursive epiphany launching prevention
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-11 16:29 UTC by Xan Lopez
Modified: 2012-12-12 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
self-launch.diff (18.42 KB, patch)
2012-12-11 16:32 UTC, Xan Lopez 		committed Details | Review
uuid.diff (4.26 KB, patch)
2012-12-11 16:44 UTC, Xan Lopez 		committed Details | Review

Description Xan Lopez 2012-12-11 16:29:14 UTC 
The way this is done is a big hack right now, so improve it!
Comment 1 Xan Lopez 2012-12-11 16:32:34 UTC 
Created attachment 231278 [details] [review]
self-launch.diff

First improve to self-launch detection. With tests!
Comment 2 Xan Lopez 2012-12-11 16:44:27 UTC 
Created attachment 231284 [details] [review]
uuid.diff

Remove the UUID stuff now.
Comment 3 Claudio Saavedra 2012-12-12 11:13:19 UTC 
Review of attachment 231278 [details] [review]:

OK, seems to make sense. Next time please split into patches doing refactoring and patches adding new stuff!

::: embed/ephy-embed-shell.c
@@ +611,3 @@
+
+/**
+ * ephy_embed_shell_launch_application:

ephy_embed_shell_launch_handler:

::: lib/ephy-file-helpers.c
@@ +765,3 @@
 	GdkDisplay *display;
 	GdkScreen *screen;
+	gboolean res = FALSE;

I'm a bit confused by this? This was just missing?
Comment 4 Claudio Saavedra 2012-12-12 11:14:42 UTC 
Review of attachment 231284 [details] [review]:

Gone with it!
Comment 5 Xan Lopez 2012-12-12 11:22:09 UTC 
(In reply to comment #3)
> Review of attachment 231278 [details] [review]:
> 
> OK, seems to make sense. Next time please split into patches doing refactoring
> and patches adding new stuff!
> 
> ::: embed/ephy-embed-shell.c
> @@ +611,3 @@
> +
> +/**
> + * ephy_embed_shell_launch_application:
> 
> ephy_embed_shell_launch_handler:
> 
> ::: lib/ephy-file-helpers.c
> @@ +765,3 @@
>      GdkDisplay *display;
>      GdkScreen *screen;
> +    gboolean res = FALSE;
> 
> I'm a bit confused by this? This was just missing?

Just a leftover from an early experiment, I can remove that.