After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690007 - improve add web app dialog
improve add web app dialog
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Web Applications
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-10 20:13 UTC by William Jon McCann
Modified: 2012-12-12 19:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update the save web app dialog to be more like the mockup (5.12 KB, patch)
2012-12-10 20:13 UTC, William Jon McCann 		reviewed Details | Review
Update the save web app dialog to be more like the mockup (5.07 KB, patch)
2012-12-12 12:04 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-12-10 20:13:06 UTC 
Will attach a patch with a number of improvements to the add webapp dialog.
Comment 1 William Jon McCann 2012-12-10 20:13:31 UTC 
Created attachment 231209 [details] [review]
Update the save web app dialog to be more like the mockup
Comment 2 Xan Lopez 2012-12-12 10:33:41 UTC 
Review of attachment 231209 [details] [review]:

Just bind the visibility of the spinner to the inverse of the image? Seems you could kill like a bunch of crap from the patch like that.
Comment 3 William Jon McCann 2012-12-12 12:04:28 UTC 
Created attachment 231346 [details] [review]
Update the save web app dialog to be more like the mockup
Comment 4 Xan Lopez 2012-12-12 12:11:58 UTC 
Comment on attachment 231346 [details] [review]
Update the save web app dialog to be more like the mockup

Bam.
Comment 5 William Jon McCann 2012-12-12 19:24:50 UTC 
Attachment 231346 [details] pushed as ad21202 - Update the save web app dialog to be more like the mockup