After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690001 - tests: Add a test for importing a module which uses literal UTF-8
tests: Add a test for importing a module which uses literal UTF-8
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-10 19:37 UTC by Colin Walters
Modified: 2012-12-11 00:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Add a test for importing a module which uses literal UTF-8 (1.21 KB, patch)
2012-12-10 19:37 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-10 19:37:42 UTC 
It was claimed to be broken.
Comment 1 Colin Walters 2012-12-10 19:37:44 UTC 
Created attachment 231196 [details] [review]
tests: Add a test for importing a module which uses literal UTF-8
Comment 2 Colin Walters 2012-12-10 23:40:00 UTC 
Attachment 231196 [details] pushed as 9ee364c - tests: Add a test for importing a module which uses literal UTF-8
Comment 3 Debarshi Ray 2012-12-11 00:09:05 UTC 
(In reply to comment #0)
> It was claimed to be broken.

I has since been fixed in:

commit c61483400bbd72866bddfca02bd465b073d9d426
Author: Giovanni Campagna <gcampagna@src.gnome.org>
Date:   Mon Oct 29 18:45:51 2012 +0100

    Convert imported modules from UTF-8 to UTF-16 before executing
    
    If JS_CStringsAreUTF8 is false, the JSAPI assumes C strings are
    ISO-8859-1. Unfortunately, we rely on that setting for byte arrays,
    so just do the conversion ourselves, like we do in gjs_context_eval().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687095