After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689977 - downloader: Error out when network is unavailable
downloader: Error out when network is unavailable
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-10 14:48 UTC by Zeeshan Ali
Modified: 2016-03-31 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure: Require glib-2.0 >= 2.32 (799 bytes, patch)
2012-12-10 14:48 UTC, Zeeshan Ali 		committed Details | Review
downloader: Error out when network is unavailable (871 bytes, patch)
2012-12-10 14:48 UTC, Zeeshan Ali 		none Details | Review
downloader: Error out if server is unreachable (1.15 KB, patch)
2012-12-10 16:22 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-12-10 14:48:47 UTC 
Error out and don't attempt to download if network is not reachable.
Comment 1 Zeeshan Ali 2012-12-10 14:48:49 UTC 
Created attachment 231147 [details] [review]
configure: Require glib-2.0 >= 2.32

With 2.34 being latest stable and 2.32 released in march, this bump
shouldn't be an issue for distros.
Comment 2 Zeeshan Ali 2012-12-10 14:48:53 UTC 
Created attachment 231148 [details] [review]
downloader: Error out when network is unavailable
Comment 3 Christophe Fergeau 2012-12-10 15:11:10 UTC 
GNetworkMonitor documentation recommends using g_network_monitor_can_reach() rather than get_network_available
Comment 4 Zeeshan Ali 2012-12-10 16:22:19 UTC 
Created attachment 231160 [details] [review]
downloader: Error out if server is unreachable
Comment 5 Alexander Larsson 2012-12-17 08:44:43 UTC 
Review of attachment 231147 [details] [review]:

ack
Comment 6 Alexander Larsson 2012-12-17 08:45:28 UTC 
Review of attachment 231160 [details] [review]:

ack
Comment 7 Zeeshan Ali 2012-12-17 14:19:00 UTC 
Attachment 231147 [details] pushed as 82a24aa - configure: Require glib-2.0 >= 2.32
Attachment 231160 [details] pushed as 575b8f1 - downloader: Error out if server is unreachable