After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689970 - e-location-entry: use new soup_session_prefetch_dns API
e-location-entry: use new soup_session_prefetch_dns API
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-10 11:51 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-12-10 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-location-entry: use new soup_session_prefetch_dns API (922 bytes, patch)
2012-12-10 11:51 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-12-10 11:51:03 UTC 
Quick update for Soup API change.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 11:51:06 UTC 
Created attachment 231142 [details] [review]
e-location-entry: use new soup_session_prefetch_dns API
Comment 2 Claudio Saavedra 2012-12-10 14:54:20 UTC 
Review of attachment 231142 [details] [review]:

::: lib/widgets/ephy-location-entry.c
@@ +947,3 @@
 
+	if (helper->uri)
+		soup_session_prefetch_dns (session, helper->uri->host, NULL, NULL, NULL);

I suppose this really doesn't need the callback, right?
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 15:14:06 UTC 
(In reply to comment #2)
> Review of attachment 231142 [details] [review]:
> 
> ::: lib/widgets/ephy-location-entry.c
> @@ +947,3 @@
> 
> +    if (helper->uri)
> +        soup_session_prefetch_dns (session, helper->uri->host, NULL, NULL,
> NULL);
> 
> I suppose this really doesn't need the callback, right?

From what I understand, no. A quick look at soup's code makes me think that.
I will ping danw.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 15:24:43 UTC 
Attachment 231142 [details] pushed as 6a9b896 - e-location-entry: use new soup_session_prefetch_dns API