After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689959 - messageTray: Don't add ourselves more than once to CtrlAltTabManager
messageTray: Don't add ourselves more than once to CtrlAltTabManager
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-10 10:12 UTC by Rui Matos
Modified: 2012-12-10 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Don't add ourselves more than once to CtrlAltTabManager (1.75 KB, patch)
2012-12-10 10:12 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-12-10 10:12:17 UTC 
We could instead prevent dupes in CtrlAltTabManager, but how do we
generally determine that 2 items are the same since they have several
parameters? *shrug* the caller can keep track I guess.
Comment 1 Rui Matos 2012-12-10 10:12:19 UTC 
Created attachment 231131 [details] [review]
messageTray: Don't add ourselves more than once to CtrlAltTabManager

This way _sessionUpdated() can be called multiple times without side
effects.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-10 10:23:32 UTC 
Review of attachment 231131 [details] [review]:

Sure.
Comment 3 Rui Matos 2012-12-10 10:51:15 UTC 
Attachment 231131 [details] pushed as c11f89e - messageTray: Don't add ourselves more than once to CtrlAltTabManager