After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689929 - New design for find bar
New design for find bar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 514429 689934 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-12-09 13:34 UTC by William Jon McCann
Modified: 2012-12-13 01:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
New design for find bar (8.50 KB, patch)
2012-12-09 13:34 UTC, William Jon McCann
none Details | Review
screenshot (98.10 KB, image/png)
2012-12-09 13:36 UTC, William Jon McCann
  Details
New design for find bar (9.40 KB, patch)
2012-12-09 15:03 UTC, William Jon McCann
none Details | Review
screenshot (95.30 KB, image/png)
2012-12-09 15:05 UTC, William Jon McCann
  Details
New design for find bar (9.53 KB, patch)
2012-12-09 20:18 UTC, William Jon McCann
none Details | Review
Clear state when clearing the find entry (1.16 KB, patch)
2012-12-09 20:18 UTC, William Jon McCann
accepted-commit_now Details | Review
Sensitize the find prev/next buttons correctly based on results (2.02 KB, patch)
2012-12-09 20:18 UTC, William Jon McCann
accepted-commit_now Details | Review
Don't close the find bar when it loses focus (2.46 KB, patch)
2012-12-09 20:18 UTC, William Jon McCann
accepted-commit_now Details | Review
screenshot (94.24 KB, image/png)
2012-12-09 20:19 UTC, William Jon McCann
  Details
New design for find bar (21.76 KB, patch)
2012-12-11 14:19 UTC, William Jon McCann
none Details | Review
screenshot (233.53 KB, image/png)
2012-12-11 14:21 UTC, William Jon McCann
  Details
New design for find bar (21.98 KB, patch)
2012-12-12 11:45 UTC, William Jon McCann
reviewed Details | Review
New design for find bar (24.16 KB, patch)
2012-12-12 17:15 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-12-09 13:34:40 UTC
In order to be more consistent with other GNOME 3 apps we should probably
move the find toolbar to the top of the page.
Comment 1 William Jon McCann 2012-12-09 13:34:42 UTC
Created attachment 231065 [details] [review]
New design for find bar

To be more consistent with other GNOME 3 apps we should move
the in page find toolbar to the top of the page.
Comment 2 William Jon McCann 2012-12-09 13:36:36 UTC
Created attachment 231066 [details]
screenshot
Comment 3 William Jon McCann 2012-12-09 13:40:54 UTC
*** Bug 514429 has been marked as a duplicate of this bug. ***
Comment 4 Allan Day 2012-12-09 14:05:14 UTC
Looks good to me. Having find at the top makes sense, since it affects the view below. This is also easier to spot; I sometimes have a hard time identifying the current find bar.

One small issue with the screenshot - the next and previous buttons need to be slightly wider.
Comment 5 William Jon McCann 2012-12-09 15:03:23 UTC
Created attachment 231075 [details] [review]
New design for find bar

Fix button widths
Comment 6 William Jon McCann 2012-12-09 15:05:29 UTC
Created attachment 231076 [details]
screenshot
Comment 7 William Jon McCann 2012-12-09 15:08:13 UTC
Though that now looks pretty assy since they buttons are taller than the entry.
Comment 8 William Jon McCann 2012-12-09 20:18:41 UTC
Created attachment 231101 [details] [review]
New design for find bar

To be more consistent with other GNOME 3 apps we should move
the in page find toolbar to the top of the page.
Comment 9 William Jon McCann 2012-12-09 20:18:44 UTC
Created attachment 231102 [details] [review]
Clear state when clearing the find entry
Comment 10 William Jon McCann 2012-12-09 20:18:47 UTC
Created attachment 231103 [details] [review]
Sensitize the find prev/next buttons correctly based on results
Comment 11 William Jon McCann 2012-12-09 20:18:50 UTC
Created attachment 231104 [details] [review]
Don't close the find bar when it loses focus

This makes it hard to drive the find from they keyboard or do a11y
keynav.
Comment 12 William Jon McCann 2012-12-09 20:19:41 UTC
Created attachment 231105 [details]
screenshot
Comment 13 William Jon McCann 2012-12-09 21:13:43 UTC
*** Bug 689934 has been marked as a duplicate of this bug. ***
Comment 14 Xan Lopez 2012-12-10 15:45:55 UTC
Review of attachment 231104 [details] [review]:

We should allow tabbing into the bar contents, but I suppose that's orthogonal to this thing.
Comment 15 Xan Lopez 2012-12-10 16:02:12 UTC
Review of attachment 231102 [details] [review]:

Yeah OK.
Comment 16 Xan Lopez 2012-12-10 16:06:55 UTC
Review of attachment 231103 [details] [review]:

Yeah (I guess this could be done in a fancy way binding properties, but whatever).
Comment 17 Lapo Calamandrei 2012-12-10 16:10:16 UTC
I think we could link the prev/next button to the entry and center it ala gnome documents, we could even style the buttons like the entry when linked to reduce  visual noise.

High quality mockup included:

---------------------------------------------------------------------------
                     [ search entry        | < | > ]  v case sensitive
---------------------------------------------------------------------------
Comment 18 William Jon McCann 2012-12-11 14:19:53 UTC
Created attachment 231261 [details] [review]
New design for find bar

To be more consistent with other GNOME 3 apps we should move
the in page find toolbar to the top of the page.
Comment 19 William Jon McCann 2012-12-11 14:21:30 UTC
Created attachment 231262 [details]
screenshot
Comment 20 Diego Escalante Urrelo (not reading bugmail) 2012-12-11 18:11:24 UTC
Although not a tracker, here are some bugs to consider/close:

Bug 323463 - "find whole word"
I think webkit does this by default.

Bug 503800 - Checkbox for case-insensitive search, why?
The bug was opened because a checkbox was added, instead of autodetecting mixed case.

Bug 333019 - Find toolbar cannot be navigated using keyboard
Comment 21 Lapo Calamandrei 2012-12-11 21:36:39 UTC
Nice, I'd use left/right arrows istead of up/down to avoid the dropdown menu effect, other then that it's much nicer then before, I'd style the close button differently (dimming it down mostly), but that's something I can fix in the theme (I hope at least).
Comment 22 Xan Lopez 2012-12-12 10:48:25 UTC
Problem with this is that we are dropping the 'Wrapped' indicator. Considering our highlight of search results already sucks, this is only making things more confusing (when searching in google.com for 'Google' I cannot for the life of me figure when I have reached the end, for example).
Comment 23 William Jon McCann 2012-12-12 11:45:07 UTC
Created attachment 231345 [details] [review]
New design for find bar

To be more consistent with other GNOME 3 apps we should move
the in page find toolbar to the top of the page.
Comment 24 Claudio Saavedra 2012-12-12 15:16:10 UTC
Review of attachment 231345 [details] [review]:

Looks good overall, but I think that we need to find a way to avoid the text shifting whe the icon pops up. I am not sure how to work that around, though, reserving the space there makes the entry look odd, too.

::: src/ephy-find-toolbar.c
@@ +227,3 @@
+str_has_uppercase (const char *str)
+{
+	while (*str) {

I'm a bit concerned that this might blow up at some point if str is NULL.
Comment 25 William Jon McCann 2012-12-12 17:15:36 UTC
Created attachment 231395 [details] [review]
New design for find bar

To be more consistent with other GNOME 3 apps we should move
the in page find toolbar to the top of the page.
Comment 26 Lapo Calamandrei 2012-12-12 18:11:15 UTC
Claudio, it would be nice to have the text shifting with class, read animation
Comment 27 Claudio Saavedra 2012-12-12 19:33:27 UTC
So we accidentally pushed this, so we can consider it fixed.
Comment 28 Lapo Calamandrei 2012-12-13 01:41:00 UTC
*cough* animation *cough*