GNOME Bugzilla – Bug 689929
New design for find bar
Last modified: 2012-12-13 01:41:00 UTC
In order to be more consistent with other GNOME 3 apps we should probably move the find toolbar to the top of the page.
Created attachment 231065 [details] [review] New design for find bar To be more consistent with other GNOME 3 apps we should move the in page find toolbar to the top of the page.
Created attachment 231066 [details] screenshot
*** Bug 514429 has been marked as a duplicate of this bug. ***
Looks good to me. Having find at the top makes sense, since it affects the view below. This is also easier to spot; I sometimes have a hard time identifying the current find bar. One small issue with the screenshot - the next and previous buttons need to be slightly wider.
Created attachment 231075 [details] [review] New design for find bar Fix button widths
Created attachment 231076 [details] screenshot
Though that now looks pretty assy since they buttons are taller than the entry.
Created attachment 231101 [details] [review] New design for find bar To be more consistent with other GNOME 3 apps we should move the in page find toolbar to the top of the page.
Created attachment 231102 [details] [review] Clear state when clearing the find entry
Created attachment 231103 [details] [review] Sensitize the find prev/next buttons correctly based on results
Created attachment 231104 [details] [review] Don't close the find bar when it loses focus This makes it hard to drive the find from they keyboard or do a11y keynav.
Created attachment 231105 [details] screenshot
*** Bug 689934 has been marked as a duplicate of this bug. ***
Review of attachment 231104 [details] [review]: We should allow tabbing into the bar contents, but I suppose that's orthogonal to this thing.
Review of attachment 231102 [details] [review]: Yeah OK.
Review of attachment 231103 [details] [review]: Yeah (I guess this could be done in a fancy way binding properties, but whatever).
I think we could link the prev/next button to the entry and center it ala gnome documents, we could even style the buttons like the entry when linked to reduce visual noise. High quality mockup included: --------------------------------------------------------------------------- [ search entry | < | > ] v case sensitive ---------------------------------------------------------------------------
Created attachment 231261 [details] [review] New design for find bar To be more consistent with other GNOME 3 apps we should move the in page find toolbar to the top of the page.
Created attachment 231262 [details] screenshot
Although not a tracker, here are some bugs to consider/close: Bug 323463 - "find whole word" I think webkit does this by default. Bug 503800 - Checkbox for case-insensitive search, why? The bug was opened because a checkbox was added, instead of autodetecting mixed case. Bug 333019 - Find toolbar cannot be navigated using keyboard
Nice, I'd use left/right arrows istead of up/down to avoid the dropdown menu effect, other then that it's much nicer then before, I'd style the close button differently (dimming it down mostly), but that's something I can fix in the theme (I hope at least).
Problem with this is that we are dropping the 'Wrapped' indicator. Considering our highlight of search results already sucks, this is only making things more confusing (when searching in google.com for 'Google' I cannot for the life of me figure when I have reached the end, for example).
Created attachment 231345 [details] [review] New design for find bar To be more consistent with other GNOME 3 apps we should move the in page find toolbar to the top of the page.
Review of attachment 231345 [details] [review]: Looks good overall, but I think that we need to find a way to avoid the text shifting whe the icon pops up. I am not sure how to work that around, though, reserving the space there makes the entry look odd, too. ::: src/ephy-find-toolbar.c @@ +227,3 @@ +str_has_uppercase (const char *str) +{ + while (*str) { I'm a bit concerned that this might blow up at some point if str is NULL.
Created attachment 231395 [details] [review] New design for find bar To be more consistent with other GNOME 3 apps we should move the in page find toolbar to the top of the page.
Claudio, it would be nice to have the text shifting with class, read animation
So we accidentally pushed this, so we can consider it fixed.
*cough* animation *cough*