After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689868 - extensions in symlinked folders not loading
extensions in symlinked folders not loading
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-07 21:04 UTC by darkxst
Modified: 2012-12-08 07:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fileUtils: correctly determine file type for symbolic links (1.50 KB, patch)
2012-12-08 00:46 UTC, darkxst 		accepted-commit_now Details | Review
fileUtils: correctly determine file type for symbolic links (1.45 KB, patch)
2012-12-08 01:00 UTC, darkxst 		committed Details | Review

Description darkxst 2012-12-07 21:04:21 UTC 
gnome-shell is no longer loading extensions that live in a symlinked folder. Only extensions that are in a real directory are loaded.
Comment 1 darkxst 2012-12-08 00:46:33 UTC 
Created attachment 231014 [details] [review]
fileUtils: correctly determine file type for symbolic links

Extensions in a folder that is a symbolic link do not get loaded,
since the returned file type is unknown.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-08 00:52:39 UTC 
Review of attachment 231014 [details] [review]:

::: js/misc/fileUtils.js
@@ +34,3 @@
     }
 
+    dir.query_info_async('standard::type', Gio.FileQueryInfoFlags.NONE,

We use the string name here, and the constant name above. Sigh.

Can we use the string names everywhere?
Comment 3 darkxst 2012-12-08 01:00:31 UTC 
Created attachment 231015 [details] [review]
fileUtils: correctly determine file type for symbolic links

Extensions in a folder that is a symbolic link do not get loaded,
since the returned file type is unknown.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-08 01:12:03 UTC 
Review of attachment 231015 [details] [review]:

Works for me.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-08 07:54:03 UTC 
Attachment 231015 [details] pushed as 16c0585 - fileUtils: correctly determine file type for symbolic links