After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689859 - folks.pc requires telepathy
folks.pc requires telepathy
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-07 18:12 UTC by Patrick Ohly
Modified: 2012-12-07 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove telepathy-glib from folks.pc (1.48 KB, patch)
2012-12-07 19:44 UTC, Patrick Ohly
committed Details | Review

Description Patrick Ohly 2012-12-07 18:12:28 UTC
When compiling with --disable-telepathy-backend on a system without Telepathy, the resulting folks.pc still has a Require entry for telepathy-glib and therefore is unusable.

When compiling with Telepathy support, apps using folks.pc end up linking againstlibtelepathy-glib.so.0 even though they and libfolks don't need it.

Therefore I think that telepathy-glib should be removed from folks.pc. A folks-telepathy.pc needs to be created for the Telepathy backend, similar to folks-eds.pc. Then apps which expect Telepathy to be included in folks.pc need to be adapted.
Comment 1 Patrick Ohly 2012-12-07 19:32:07 UTC
Wait, there *is* already a folks-telepathy.pc. Then I cannot think of any reason to not just remove telepathy-glib from folks.pc.
Comment 2 Patrick Ohly 2012-12-07 19:41:58 UTC
(In reply to comment #0)
> When compiling with Telepathy support, apps using folks.pc end up linking
> againstlibtelepathy-glib.so.0 even though they and libfolks don't need it.

When removing telepathy-glib, the library is no longer linked in and everything still works.
Comment 3 Patrick Ohly 2012-12-07 19:44:41 UTC
Created attachment 230995 [details] [review]
remove telepathy-glib from folks.pc
Comment 4 Philip Withnall 2012-12-07 19:49:02 UTC
Review of attachment 230995 [details] [review]:

Good catch. Please push to master!
Comment 5 Patrick Ohly 2012-12-07 19:58:14 UTC
Committed as 8c4ec6251