After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689815 - build: Allow disabling cairo
build: Allow disabling cairo
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-06 21:45 UTC by Colin Walters
Modified: 2012-12-06 22:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Allow disabling cairo (2.61 KB, patch)
2012-12-06 21:45 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-06 21:45:52 UTC 
I want to use gjs on a server which doesn't have cairo installed.
Comment 1 Colin Walters 2012-12-06 21:45:56 UTC 
Created attachment 230926 [details] [review]
build: Allow disabling cairo
Comment 2 Owen Taylor 2012-12-06 21:54:12 UTC 
Review of attachment 230926 [details] [review]:

::: configure.ac
@@ +112,3 @@
+AC_ARG_WITH(cairo,
+	    AS_HELP_STRING([--without-cairo], [Do not use cairo @<:@default=no@:>@]),
+	    [], [with_cairo=yes])

are you sure this works out right for the default=no; --without-cairo is a synonym for --with-cairo=yes - I'm not sure you can double-negative and say --without-cairo=no. Suggest maybe just going with --with-cairo with a default of yes for minimum confusion.

@@ +119,3 @@
+  ])
+])
+AM_CONDITIONAL(ENABLE_CAIRO, test x$enable_cairo = xyes)

enable vs. with confusion (and elsewhere)
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-06 21:54:13 UTC 
Review of attachment 230926 [details] [review]:

OK
Comment 4 Colin Walters 2012-12-06 22:00:39 UTC 
Fixed up both issues, thanks!

Attachment 230926 [details] pushed as 5bcdc19 - build: Allow disabling cairo