After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689762 - Obsolete WebKit2 favicons API used in bookmarks
Obsolete WebKit2 favicons API used in bookmarks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-06 09:41 UTC by Carlos Garcia Campos
Modified: 2012-12-07 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to use the right API (3.72 KB, patch)
2012-12-06 09:41 UTC, Carlos Garcia Campos 		accepted-commit_now Details | Review

Description Carlos Garcia Campos 2012-12-06 09:41:13 UTC 
Created attachment 230879 [details] [review]
Patch to use the right API

The signal favicon-ready, should have never existed :-(
Comment 1 Mario Sánchez Prada 2012-12-07 08:28:13 UTC 
Agreed, and I recognize my fault in here, as I'm the one who committed the patch for the favicons API.

Anyway, the patch Carlos is proposing here looks good to me and I think we should commit it asap, to avoid having epiphany in an inconsistent state.

Sorry for the mess
Comment 2 Xan Lopez 2012-12-07 11:05:19 UTC 
Review of attachment 230879 [details] [review]:

OK then!