After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689743 - application.js: Set import versions
application.js: Set import versions
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-05 22:40 UTC by Colin Walters
Modified: 2012-12-05 23:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application.js: Set import versions (1.12 KB, patch)
2012-12-05 22:40 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-05 22:40:11 UTC 
Future versions of gjs will likely warn when doing "unversioned"
imports.

See https://bugzilla.gnome.org/show_bug.cgi?id=689654
Comment 1 Colin Walters 2012-12-05 22:40:12 UTC 
Created attachment 230846 [details] [review]
application.js: Set import versions
Comment 2 Cosimo Cecchi 2012-12-05 22:50:06 UTC 
Review of attachment 230846 [details] [review]:

Does this require the gjs patch? Looks good to me either way, thanks.
Comment 3 Colin Walters 2012-12-05 23:25:04 UTC 
(In reply to comment #2)
> Review of attachment 230846 [details] [review]:
> 
> Does this require the gjs patch? 

Nope, imports.gi.versions has existed for quite a while, just no one has been using it really.

> Looks good to me either way, thanks.

Thanks!
Comment 4 Colin Walters 2012-12-05 23:26:58 UTC 
Attachment 230846 [details] pushed as b26cf77 - application.js: Set import versions