After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689738 - extensions: Install a 'classic' mode for gnome-shell
extensions: Install a 'classic' mode for gnome-shell
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 685744
 
 
Reported: 2012-12-05 21:15 UTC by Florian Müllner
Modified: 2012-12-10 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add generated data files to .gitignore (571 bytes, patch)
2012-12-05 21:15 UTC, Florian Müllner 		committed Details | Review
Install a 'classic' mode for gnome-shell (3.14 KB, patch)
2012-12-05 21:15 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-12-05 21:15:19 UTC 
Now that external session-modes have landed, we can install one similar to the gnome-session machinery landed in commit c421da905fb.
Comment 1 Florian Müllner 2012-12-05 21:15:21 UTC 
Created attachment 230828 [details] [review]
Add generated data files to .gitignore
Comment 2 Florian Müllner 2012-12-05 21:15:25 UTC 
Created attachment 230829 [details] [review]
Install a 'classic' mode for gnome-shell

Commit c421da905fb added the necessary machinery for adding a
classic session, do the same for the corresponding gnome-shell
mode.
Comment 3 Matthias Clasen 2012-12-10 20:45:10 UTC 
Review of attachment 230829 [details] [review]:

Looks good to me (and worked in my testing)
Comment 4 Giovanni Campagna 2012-12-10 21:58:22 UTC 
Review of attachment 230828 [details] [review]:

Ok
Comment 5 Giovanni Campagna 2012-12-10 22:04:28 UTC 
Review of attachment 230829 [details] [review]:

Yes.

Btw, I guess at some point we'll change the extension base to be @gnome-shell-extensions.gnome.org, given it's not my personal repository anymore.

::: data/Makefile.am
@@ +29,3 @@
+space:= $(empty) $(empty)
+extensions:=$(patsubst %,\"%$(extensionbase)\",$(CLASSIC_EXTENSIONS))
+extension_list:=$(subst $(space),$(comma),$(extensions))

Nice!
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-10 22:29:11 UTC 
Review of attachment 230829 [details] [review]:

::: data/Makefile.am
@@ +29,3 @@
+space:= $(empty) $(empty)
+extensions:=$(patsubst %,\"%$(extensionbase)\",$(CLASSIC_EXTENSIONS))
+extension_list:=$(subst $(space),$(comma),$(extensions))

Yeah, I want to point out that this is pretty amazing.
Comment 7 Giovanni Campagna 2012-12-10 23:09:09 UTC 
Umpf, I was just tested this, but accidentally pushed it.
Sorry I stole your credits :)