After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689727 - gnome-documents.in cleanups
gnome-documents.in cleanups
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-05 19:35 UTC by Colin Walters
Modified: 2012-12-05 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-documents.in: Use shorter syntax for LD_LIBRARY_PATH etc. fiddling (1.34 KB, patch)
2012-12-05 19:35 UTC, Colin Walters 		committed Details | Review
gnome-documents.in: Don't leave shell interpreter hanging around (1.07 KB, patch)
2012-12-05 19:35 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-05 19:35:10 UTC 
Just noticed while reading the source for other reasons.
Comment 1 Colin Walters 2012-12-05 19:35:12 UTC 
Created attachment 230811 [details] [review]
gnome-documents.in: Use shorter syntax for LD_LIBRARY_PATH etc. fiddling

This is one line vs 5.
Comment 2 Colin Walters 2012-12-05 19:35:14 UTC 
Created attachment 230812 [details] [review]
gnome-documents.in: Don't leave shell interpreter hanging around

Basically, wrapper shell scripts like this should always end in 'exec'
- otherwise you have a pointless process hanging around.  Even worse,
because gnome-documents.in doesn't use "set -e", the shell script will
actually mask return values if e.g. the gjs process exits abormally.
Comment 3 Colin Walters 2012-12-05 19:39:24 UTC 
Got IRC approval
Comment 4 Colin Walters 2012-12-05 19:39:38 UTC 
Attachment 230811 [details] pushed as 2534ac7 - gnome-documents.in: Use shorter syntax for LD_LIBRARY_PATH etc. fiddling
Attachment 230812 [details] pushed as 92726c9 - gnome-documents.in: Don't leave shell interpreter hanging around