Created attachment 230802 [details] [review]
alternate-tab: Re-use window-switcher in gnome-shell

gnome-shell now provides its own traditional window switcher using
a dedicated keybinding, so update the extension to just take over
the default application-based switchers as well.

Created attachment 230844 [details] [review]
alternate-tab: Re-use window-switcher in gnome-shell

Don't break distcheck :(

Review of attachment 230844 [details] [review]:

::: extensions/alternate-tab/extension.js
@@ +56,2 @@
     setKeybinding('switch-group', Lang.bind(Main.wm, Main.wm._startAppSwitcher));
     setKeybinding('switch-windows-backward', Lang.bind(Main.wm, Main.wm._startAppSwitcher));

missed this?

Created attachment 230845 [details] [review]
alternate-tab: Re-use window-switcher in gnome-shell

Yeah ...

Typo alert:
-const Clutter = imports.gi.Clutter;

Clutter.Left and Clutter.Right are being used, so Clutter is needed.

Created attachment 231046 [details] [review]
alternate-tab: Re-use window-switcher in gnome-shell

Fixing aforementioned typo.

Review of attachment 231046 [details] [review]:

I was thinking actually of dropping alternate-tab, given it is in core now, but given we're using extensions as a cheap way to override settings this one is probably fine.

::: extensions/alternate-tab/extension.js
@@ +50,3 @@
+    setKeybinding('switch-group', Lang.bind(Main.wm, Main.wm._startWindowSwitcher));
+    setKeybinding('switch-applications-backward', Lang.bind(Main.wm, Main.wm._startWindowSwitcher));
+    setKeybinding('switch-group-backward', Lang.bind(Main.wm, Main.wm._startWindowSwitcher));

Uhm... you're still binding Main.wm._startWindowSwitcher, that is, you're not changing the handler.

(In reply to comment #7)
> Uhm... you're still binding Main.wm._startWindowSwitcher, that is, you're not
> changing the handler.

I am, from Main.wm._start*App*Switcher to Main.wm._start*Window*Switcher.

Review of attachment 231046 [details] [review]:

Ah, obviously...

Attachment 231046 [details] pushed as 61f86a3 - alternate-tab: Re-use window-switcher in gnome-shell