GNOME Bugzilla – Bug 689681
Overview Search does not scroll
Last modified: 2013-03-12 23:32:23 UTC
Overview Search results can sometimes extend past the bottom of the screen. In this case, a scroll bar is placed, allowing a user to scroll by mouse. However, Overview Search allows the use of arrow keys to guide search result selection, but does not scroll with the selection. In other words, it is possible for a user to make a selection which is not visible on the screen. Overview Search's scrolling should follow the arrow key selection, just like in Nautilus.
Can confirm that the issue exists. It happens whenever a search in the overview has more lines than can fit on the screen. Keyboard navigation does not scroll the list on the screen.
Created attachment 238609 [details] [review] appDisplay: Move ensureIconVisible logic to util, make it more generic In particular, make it work if we have multiple parents, like in the search case.
Created attachment 238610 [details] [review] searchDisplay: Scroll the search results when using keynav This makes keynav for search results much more usable.
annoying issue in a very important feature. lets put this on the 3.8 blocker list
Review of attachment 238609 [details] [review]: Looks fine in principle, but I have a question on the code: ::: js/misc/util.js @@ +258,3 @@ + let box = parent.get_allocation_box(); + y1 += box.y1; + I don't really understand what these sums are trying to accomplish...why is the box of the last parent before the scrollView alone not enough?
Review of attachment 238610 [details] [review]: ++
(In reply to comment #5) > I don't really understand what these sums are trying to accomplish...why is the > box of the last parent before the scrollView alone not enough? We're trying to find the position of a search result relative to the scroll view. In the app display case, it's a direct child of the scroll view, but in the search case, there's lots of boxes between this and the scrollView. Thus, we need to traverse up the tree, as the allocation is relative to its parent.
(In reply to comment #7) > We're trying to find the position of a search result relative to the scroll > view. In the app display case, it's a direct child of the scroll view, but in > the search case, there's lots of boxes between this and the scrollView. Thus, > we need to traverse up the tree, as the allocation is relative to its parent. OK makes sense to me then.
Attachment 238609 [details] pushed as 5870709 - appDisplay: Move ensureIconVisible logic to util, make it more generic Attachment 238610 [details] pushed as 42d45bd - searchDisplay: Scroll the search results when using keynav