After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689681 - Overview Search does not scroll
Overview Search does not scroll
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-05 09:06 UTC by lmeditato
Modified: 2013-03-12 23:32 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
appDisplay: Move ensureIconVisible logic to util, make it more generic (3.60 KB, patch)
2013-03-11 18:23 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
searchDisplay: Scroll the search results when using keynav (3.36 KB, patch)
2013-03-11 18:23 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description lmeditato 2012-12-05 09:06:46 UTC
Overview Search results can sometimes extend past the bottom of the screen. In this case, a scroll bar is placed, allowing a user to scroll by mouse. However, Overview Search allows the use of arrow keys to guide search result selection, but does not scroll with the selection. In other words, it is possible for a user to make a selection which is not visible on the screen. Overview Search's scrolling should follow the arrow key selection, just like in Nautilus.
Comment 1 Sajo Mathews 2013-02-11 05:22:13 UTC
Can confirm that the issue exists. 
It happens whenever a search in the overview has more lines than can fit on the screen. 
Keyboard navigation does not scroll the list on the screen.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-11 18:23:54 UTC
Created attachment 238609 [details] [review]
appDisplay: Move ensureIconVisible logic to util, make it more generic

In particular, make it work if we have multiple parents, like in the
search case.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-11 18:23:58 UTC
Created attachment 238610 [details] [review]
searchDisplay: Scroll the search results when using keynav

This makes keynav for search results much more usable.
Comment 4 Matthias Clasen 2013-03-12 10:17:39 UTC
annoying issue in a very important feature. lets put this on the 3.8 blocker list
Comment 5 Cosimo Cecchi 2013-03-12 14:25:24 UTC
Review of attachment 238609 [details] [review]:

Looks fine in principle, but I have a question on the code:

::: js/misc/util.js
@@ +258,3 @@
+        let box = parent.get_allocation_box();
+        y1 += box.y1;
+

I don't really understand what these sums are trying to accomplish...why is the box of the last parent before the scrollView alone not enough?
Comment 6 Cosimo Cecchi 2013-03-12 14:27:03 UTC
Review of attachment 238610 [details] [review]:

++
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-03-12 15:24:06 UTC
(In reply to comment #5)
> I don't really understand what these sums are trying to accomplish...why is the
> box of the last parent before the scrollView alone not enough?

We're trying to find the position of a search result relative to the scroll view. In the app display case, it's a direct child of the scroll view, but in the search case, there's lots of boxes between this and the scrollView. Thus, we need to traverse up the tree, as the allocation is relative to its parent.
Comment 8 Cosimo Cecchi 2013-03-12 23:26:00 UTC
(In reply to comment #7)

> We're trying to find the position of a search result relative to the scroll
> view. In the app display case, it's a direct child of the scroll view, but in
> the search case, there's lots of boxes between this and the scrollView. Thus,
> we need to traverse up the tree, as the allocation is relative to its parent.

OK makes sense to me then.
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-03-12 23:32:17 UTC
Attachment 238609 [details] pushed as 5870709 - appDisplay: Move ensureIconVisible logic to util, make it more generic
Attachment 238610 [details] pushed as 42d45bd - searchDisplay: Scroll the search results when using keynav