After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689674 - Use a default value for the pixbuf cache
Use a default value for the pixbuf cache
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 689505 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-12-05 02:25 UTC by William Jon McCann
Modified: 2012-12-12 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set a good default value for the pixbuf cache (1.10 KB, patch)
2012-12-05 02:26 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-12-05 02:25:41 UTC 
It would be nice to have a good default value for the pixbuf cache so that every app that uses it doesn't have to do it manually. For instance, in Documents we didn't even realize that we had to set it at first. It works much better when it is non-zero.
Comment 1 William Jon McCann 2012-12-05 02:26:21 UTC 
Created attachment 230716 [details] [review]
Set a good default value for the pixbuf cache

This makes it easier for consumers of EvView to have good
performance out of the box.
Comment 2 Carlos Garcia Campos 2012-12-06 11:44:49 UTC 
Review of attachment 230716 [details] [review]:

Good point, thanks!

::: libview/ev-view.c
@@ +100,3 @@
 #define SCROLL_TIME 150
 
+#define PIXBUF_CACHE_SIZE 52428800 /* 50MB */

Could you renamed it to DEFAULT_PIXBUF_CACHE_SIZE? to make it clear that's only the default values used by the view.
Comment 3 Cosimo Cecchi 2012-12-12 23:31:52 UTC 
*** Bug 689505 has been marked as a duplicate of this bug. ***