After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689659 - strings: Avoid copy of utf16 data in case where g_mem_is_system_malloc()
strings: Avoid copy of utf16 data in case where g_mem_is_system_malloc()
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-04 21:38 UTC by Colin Walters
Modified: 2012-12-04 23:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
strings: Avoid copy of utf16 data in case where g_mem_is_system_malloc() (1.31 KB, patch)
2012-12-04 21:38 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2012-12-04 21:38:21 UTC
This should be the common case.  Just noticed this while reading the
code for unrelated reasons.
Comment 1 Colin Walters 2012-12-04 21:38:23 UTC
Created attachment 230703 [details] [review]
strings: Avoid copy of utf16 data in case where g_mem_is_system_malloc()
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-04 21:50:03 UTC
Review of attachment 230703 [details] [review]:

Fine with me.
Comment 3 Colin Walters 2012-12-04 23:29:00 UTC
Attachment 230703 [details] pushed as bd8d0f2 - strings: Avoid copy of utf16 data in case where g_mem_is_system_malloc()