After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689658 - Request for backport of fix for custom paper sizes in GTK Print Dialog
Request for backport of fix for custom paper sizes in GTK Print Dialog
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
2.24.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-12-04 20:49 UTC by Peter Klotz
Modified: 2012-12-16 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch against GTK+ 2.24.13 (tested successfully) (576 bytes, patch)
2012-12-04 20:49 UTC, Peter Klotz
none Details | Review

Description Peter Klotz 2012-12-04 20:49:32 UTC
Created attachment 230702 [details] [review]
The patch against GTK+ 2.24.13 (tested successfully)

In bug #679883 a two line patch was applied to GTK+ 3.x that fixes a problem when using custom paper sizes in the GTK print dialog.

This problem for example affects the current Inkscape version 0.48.2 which still uses GTK+ 2.

Therefore it would be great if this simple fix could be applied to the next GTK+ 2.x release.

The problem can be observed in an up-to-date Arch Linux installation:

https://bugs.archlinux.org/task/32227?opened=11339&status%5B0%5D=
Comment 1 Michael Natterer 2012-12-16 18:21:11 UTC
Done:

commit d9f9925878773fb37d1a385a929ddcbb4ef8fb80
Author: Marek Kasik <mkasik@redhat.com>
Date:   Tue Sep 18 14:18:15 2012 +0200

    printing: Add "Custom." prefix only once to paper size
    
    Check whether "Custom." prefix is already present in the name
    of selected paper size. (#679883)
    (cherry picked from commit be7752183eb07274b67036362f895b31aa28eb25)

 modules/printbackends/cups/gtkprintbackendcups.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)