GNOME Bugzilla – Bug 689651
Increase typical icon size to 96
Last modified: 2012-12-10 01:46:42 UTC
See patch. This was pointed out by Benoir (I hope I spelled your name right) on IRC yesterday. This is a quick hack patch. I'll refactor this code to trash the cache in the future.
Created attachment 230688 [details] [review] Increase typical icon size to 96 Since we want nice alt-tab applications for gnome-shell, we should up the limit to 96. In the future, we probably want to get rid of the icon-cache, and allow looking up a correctly sized icon directly from the window. To prevent app breakage, set the legacy WM_HINTS pixmap size directly to 32x32.
Review of attachment 230688 [details] [review]: So my biggest concern was the find_best_size function in iconcache.c wouldn't deal very well the number being higher than 32 (since icons will often be 32) and that function has this comment: /* if we have too large, pick anything smaller• * but still >= the ideal• */• ideal is now 96, and so I feared since 32 is not >= 96 some applications would stop getting icons. After writing a test case, and rereading through the code I found that it does indeed allow less than ideal sized icons if that's all that available, so my concern there is gone. otherwise, looks good. ::: src/core/screen.c @@ +316,3 @@ + vals[1] = 32; + vals[2] = 32; + vals[3] = 32; probably should have a comment here explaining why this isn't META_ICON_WIDTH/META_ICON_HEIGHT but bare literals. Alternatively, could create a new #define META_ICON_LEGACY_ICON_SIZE or something
Attachment 230688 [details] pushed as 9d904f9 - Increase typical icon size to 96