After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689642 - Cancel buttons do not work
Cancel buttons do not work
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.6.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on: 688751
Blocks:
 
 
Reported: 2012-12-04 16:37 UTC by Debarshi Ray
Modified: 2013-01-08 17:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
httpclient: Fix cancellation (1.59 KB, patch)
2012-12-05 16:11 UTC, Debarshi Ray 		committed Details | Review
httpclient: Set the error if cancelled (997 bytes, patch)
2012-12-05 16:11 UTC, Debarshi Ray 		rejected Details | Review
owncloud: Make the cancel button work (4.99 KB, patch)
2012-12-05 16:12 UTC, Debarshi Ray 		committed Details | Review
owncloud: Fix the error propagation in refresh_account (1.66 KB, patch)
2012-12-05 16:13 UTC, Debarshi Ray 		committed Details | Review
ewsclient: Set the error if cancelled (1.14 KB, patch)
2012-12-05 16:13 UTC, Debarshi Ray 		none Details | Review
ewsclient: Always set the op_res when completing the operation (988 bytes, patch)
2012-12-05 16:14 UTC, Debarshi Ray 		committed Details | Review
ewsclient: Fix cancellation (1.68 KB, patch)
2012-12-05 16:14 UTC, Debarshi Ray 		committed Details | Review
exchange: Make the cancel button work (5.15 KB, patch)
2012-12-05 16:15 UTC, Debarshi Ray 		committed Details | Review
exchange: Fix the error propagation in refresh_account (1.68 KB, patch)
2012-12-05 16:24 UTC, Debarshi Ray 		committed Details | Review
ewsclient: Differentiate between short-circuited and cancelled messages (2.38 KB, patch)
2012-12-05 18:54 UTC, Debarshi Ray 		committed Details | Review
ewsclient: Use g_simple_async_result_set_check_cancellable (971 bytes, patch)
2012-12-05 18:55 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-12-04 16:37:40 UTC 
The cancel buttons in the exchange, kerberos and owncloud dialogs do not work as expected.
Comment 1 Debarshi Ray 2012-12-05 16:11:23 UTC 
Created attachment 230780 [details] [review]
httpclient: Fix cancellation
Comment 2 Debarshi Ray 2012-12-05 16:11:52 UTC 
Created attachment 230781 [details] [review]
httpclient: Set the error if cancelled
Comment 3 Debarshi Ray 2012-12-05 16:12:23 UTC 
Created attachment 230783 [details] [review]
owncloud: Make the cancel button work
Comment 4 Debarshi Ray 2012-12-05 16:13:12 UTC 
Created attachment 230784 [details] [review]
owncloud: Fix the error propagation in refresh_account
Comment 5 Debarshi Ray 2012-12-05 16:13:38 UTC 
Created attachment 230785 [details] [review]
ewsclient: Set the error if cancelled
Comment 6 Debarshi Ray 2012-12-05 16:14:06 UTC 
Created attachment 230786 [details] [review]
ewsclient: Always set the op_res when completing the operation
Comment 7 Debarshi Ray 2012-12-05 16:14:37 UTC 
Created attachment 230787 [details] [review]
ewsclient: Fix cancellation
Comment 8 Debarshi Ray 2012-12-05 16:15:20 UTC 
Created attachment 230788 [details] [review]
exchange: Make the cancel button work
Comment 9 Debarshi Ray 2012-12-05 16:24:34 UTC 
Created attachment 230791 [details] [review]
exchange: Fix the error propagation in refresh_account
Comment 10 Debarshi Ray 2012-12-05 18:52:37 UTC 
Comment on attachment 230781 [details] [review]
httpclient: Set the error if cancelled

g_simple_async_result_set_check_cancellable takes care of it.
Comment 11 Debarshi Ray 2012-12-05 18:54:21 UTC 
Created attachment 230804 [details] [review]
ewsclient: Differentiate between short-circuited and cancelled messages
Comment 12 Debarshi Ray 2012-12-05 18:55:25 UTC 
Created attachment 230805 [details] [review]
ewsclient: Use g_simple_async_result_set_check_cancellable
Comment 13 Debarshi Ray 2012-12-05 19:01:40 UTC 
Unless bug 688751 is fixed, clicking the cancel button in the exchange and owncloud dialogs might lead to a deadlock.
Comment 14 Debarshi Ray 2013-01-08 17:02:51 UTC 
Bug 688751 has now been fixed. Closing.