After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689638 - use symbolic icons
use symbolic icons
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-04 15:20 UTC by William Jon McCann
Modified: 2013-02-01 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup (55.24 KB, image/png)
2012-12-04 15:31 UTC, Allan Day
  Details
Use symbolic icons in the device list (3.79 KB, patch)
2012-12-04 16:01 UTC, William Jon McCann
none Details | Review
Use symbolic icons in the device list (3.77 KB, patch)
2012-12-04 16:06 UTC, William Jon McCann
none Details | Review
Use symbolic icons for network devices (6.14 KB, patch)
2012-12-04 16:14 UTC, William Jon McCann
none Details | Review
Use symbolic icons for network devices (6.37 KB, patch)
2012-12-04 18:01 UTC, William Jon McCann
committed Details | Review
screenshot (37.20 KB, image/png)
2012-12-04 18:02 UTC, William Jon McCann
  Details

Description William Jon McCann 2012-12-04 15:20:02 UTC
I think it might be better to use symbolic icons for the network items in the left bar.
Comment 1 Allan Day 2012-12-04 15:31:40 UTC
Created attachment 230667 [details]
mockup

Here's a quick experiment to see what it would look like.
Comment 2 William Jon McCann 2012-12-04 16:01:35 UTC
Created attachment 230670 [details] [review]
Use symbolic icons in the device list
Comment 3 William Jon McCann 2012-12-04 16:06:24 UTC
Created attachment 230672 [details] [review]
Use symbolic icons in the device list
Comment 4 William Jon McCann 2012-12-04 16:14:50 UTC
Created attachment 230673 [details] [review]
Use symbolic icons for network devices

This is consistent with the guideline to use symbolic icons for
classes and reserve full color icons for "things" like apps, people,
documents, pages, etc.

It is also consistent with how these devices are displayed in the
network menu, notifications, and dialogs.
Comment 5 William Jon McCann 2012-12-04 18:01:43 UTC
Created attachment 230681 [details] [review]
Use symbolic icons for network devices

More padding
Comment 6 William Jon McCann 2012-12-04 18:02:40 UTC
Created attachment 230682 [details]
screenshot
Comment 7 Bastien Nocera 2012-12-06 13:43:08 UTC
The wired icon in the left hand pane is unreadable.
Comment 8 Matthias Clasen 2012-12-07 21:14:18 UTC
it looks like it is just the wrong icon ? looks like 'wired disconnected' or somesuch
Comment 9 Bastien Nocera 2012-12-10 08:20:48 UTC
(In reply to comment #8)
> it looks like it is just the wrong icon ? looks like 'wired disconnected' or
> somesuch

The icon in the left-hand pane follows the state of the device. It's a disconnected device on my desktop machine which doesn't use wired connections as well.
Comment 10 Matthias Clasen 2012-12-11 11:02:44 UTC
ah, right. looks like that symbolic icon needs improvement, then
Comment 11 Jakub Steiner 2012-12-11 13:57:01 UTC
I don't quite follow. You guys don't think that is an appropriate metaphor for a disconnected ethernet device?
Comment 12 William Jon McCann 2012-12-11 14:26:12 UTC
No, I think they are saying that the "category" icons in the left pane shouldn't show the status of the device.
Comment 13 Bastien Nocera 2012-12-11 15:51:19 UTC
(In reply to comment #12)
> No, I think they are saying that the "category" icons in the left pane
> shouldn't show the status of the device.

Neither. It's that the icon is nearly invisible when the line is not selected. Whether that means using an icon that doesn't follow the state of the device, or another icon, is really up to you guys.
Comment 14 Bastien Nocera 2013-01-30 18:55:05 UTC
What do we do here?
- not follow the state of the device in the list of devices, so that the icon isn't so dim?
- use this patch as-is anyway on the basis that the text is the primary carrier of information and that the icon is simply additional metadata?
Comment 15 Bastien Nocera 2013-01-30 19:00:54 UTC
Attachment 230681 [details] pushed as e2094d8 - Use symbolic icons for network devices
Comment 16 Bastien Nocera 2013-01-30 19:02:39 UTC
I pushed this by mistake. I guess you can open a new bug if you're not happy about the result ;)
Comment 17 Matthias Clasen 2013-02-01 13:12:07 UTC
See bug 693001