After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689616 - Use a bit safer environment getters.
Use a bit safer environment getters.
Status: RESOLVED FIXED
Product: gupnp-dlna
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-04 12:37 UTC by Krzesimir Nowak
Modified: 2019-02-22 06:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use g_get_environ and g_environ_getenv instead of g_getenv. (1.69 KB, patch)
2012-12-04 12:37 UTC, Krzesimir Nowak 		committed Details | Review

Description Krzesimir Nowak 2012-12-04 12:37:29 UTC 
Created attachment 230648 [details] [review]
Use g_get_environ and g_environ_getenv instead of g_getenv.

g_getenv() docs say that a string might be overwritten on next call to g_getenv(). This creates a risk that a value of GUPNP_DLNA_METADATA_BACKEND will be overwritten or contain some garbage when getting value of GUPNP_DLNA_METADATA_BACKEND_DIR.