After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689611 - "Enabled" isn't a good label for the global switch
"Enabled" isn't a good label for the global switch
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Search
git master
Other Linux
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on: 692174
Blocks:
 
 
Reported: 2012-12-04 11:42 UTC by Allan Day
Modified: 2013-02-18 15:42 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
search: don't use a label for the enabled switch (886 bytes, patch)
2013-02-17 19:34 UTC, William Jon McCann 		committed Details | Review

Description Allan Day 2012-12-04 11:42:23 UTC 
The switch already says on and off. "Enabled" is just repetition.

Alternatives could be "System Search" or "Activities Overview Search".
Comment 1 Cosimo Cecchi 2012-12-04 18:51:14 UTC 
I think I like "System Search" better, but still it doesn't feel completely right.
For the way the dialog is currently structured, what we're disabling with the toggle is application-provided search - you would still be able to search for applications - but I can't come up with a better wording at the moment.
Comment 2 Adam Matoušek 2013-01-25 14:56:35 UTC 
What about "Content Search"? Everything that is not an application can be considered "content", right?
Nothing but a suggestion.
Comment 3 William Jon McCann 2013-01-25 19:34:48 UTC 
If we use the GNOME 3 toolbar/titlebar style with "Search" on the same row as the switch we can remove the label.
Comment 4 Allan Day 2013-02-13 14:32:51 UTC 
(In reply to comment #3)
> If we use the GNOME 3 toolbar/titlebar style with "Search" on the same row as
> the switch we can remove the label.

I agree that this would be a better solution.
Comment 5 William Jon McCann 2013-02-17 19:34:41 UTC 
Created attachment 236484 [details] [review]
search: don't use a label for the enabled switch
Comment 6 Bastien Nocera 2013-02-18 08:28:08 UTC 
Review of attachment 236484 [details] [review]:

Add a reference to the previous commit, or some details. The commit message is lacking on the "why".