After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689603 - content-synchronization DLNA cap support
content-synchronization DLNA cap support
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-core
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-04 10:40 UTC by regis.merlino
Modified: 2012-12-05 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch proposal (1023 bytes, patch)
2012-12-04 10:40 UTC, regis.merlino 		needs-work Details | Review
Proposal v2 (987 bytes, patch)
2012-12-04 12:40 UTC, regis.merlino 		committed Details | Review

Description regis.merlino 2012-12-04 10:40:47 UTC 
Created attachment 230638 [details] [review]
Patch proposal

'content-synchronization' capability should be added to DLNA caps when the plugin supports PluginCapabilities.TRACK_CHANGES.

A patch proposal is attached.
Comment 1 Jens Georg 2012-12-04 11:17:10 UTC 
Review of attachment 230638 [details] [review]:

::: src/librygel-core/rygel-description-file.vala
@@ +161,3 @@
             }
 
+            if((PluginCapabilities.TRACK_CHANGES & capabilities) != 0) {

please use the "in" keyword for checking presence of flags
Comment 2 regis.merlino 2012-12-04 12:40:53 UTC 
Created attachment 230649 [details] [review]
Proposal v2