After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689602 - Add macros to check strings for common problems
Add macros to check strings for common problems
Status: RESOLVED WONTFIX
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-04 10:40 UTC by Philip Withnall
Modified: 2015-03-05 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add macros to check strings for common problems (4.68 KB, patch)
2013-08-08 11:07 UTC, Philip Withnall
none Details | Review

Description Philip Withnall 2012-12-04 10:40:33 UTC
Ted Gould has written some automake fragments to check translatable strings for some common problems relating to Unicode ellipses:

https://mail.gnome.org/archives/desktop-devel-list/2012-December/msg00008.html
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-session/trunk.13.04/view/head:/tests/Makefile.am.strings

It would be good if these could be turned into fully-fledged automake macros and included in gnome-common. There’s probably scope to cover other common problems in translatable strings too (perhaps markup in strings?) although we’d have to be careful to handle false positives in a non-annoying way.
Comment 1 Philip Withnall 2013-08-08 11:07:02 UTC
Created attachment 251135 [details] [review]
Add macros to check strings for common problems

WIP patch to port Ted’s recipes to gnome-common. It has two problems:
 • I can’t figure out how to quote the single quotation mark in the check-ascii-quotes recipe.
 • The original code was under GPLv3, so needs to be relicenced to LGPLv2.1+.

Once those are fixed, potentially some more checks could be added, then the whole thing needs a bit more thorough testing. I’m stalled on this at the moment, though, because I have run out of ideas for fixing the string quoting problem.
Comment 2 Philip Withnall 2014-05-02 15:04:44 UTC
After discussion with David at the developer hackfest, we’ve decided that this doesn’t really belong in gnome-common, because it’s not GNOME-specific.

It either belongs upstream in gettext, as here:
 • http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=10d925d18a1fb0203986c614540b88f321c1b4da
or belongs in autoconf-archive:
 • http://www.gnu.org/software/autoconf-archive/

I’ll leave this bug open until someone’s had a chance to investigate which of those two options would be preferable (for GNOME and for the wider FOSS ecosystem).
Comment 3 David King 2015-01-26 15:12:43 UTC
Let's do this in gettext instead (as discussed at the developer experience hackfest).
Comment 4 Philip Withnall 2015-01-27 10:50:48 UTC
(In reply to comment #3)
> Let's do this in gettext instead (as discussed at the developer experience
> hackfest).https://savannah.gnu.org/bugs/index.php?44098
Comment 5 Philip Withnall 2015-03-05 20:38:18 UTC
(In reply to Philip Withnall from comment #4)
> (In reply to comment #3)
> > Let's do this in gettext instead (as discussed at the developer experience
> > hackfest).
> 
> → https://savannah.gnu.org/bugs/index.php?44098

Implemented in xgettext: https://savannah.gnu.org/bugs/?44098#comment9