After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689570 - Fix doctool Makefile.am-ery
Fix doctool Makefile.am-ery
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-03 21:34 UTC by Dieter Verfaillie
Modified: 2015-02-07 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: fix incremental build (1.74 KB, patch)
2012-12-03 21:39 UTC, Dieter Verfaillie 		committed Details | Review
tests: don't fake Automake silent mode (1.33 KB, patch)
2012-12-03 21:40 UTC, Dieter Verfaillie 		committed Details | Review
tests: ignore errors returned by rm -f (998 bytes, patch)
2012-12-03 21:41 UTC, Dieter Verfaillie 		rejected Details | Review

Description Dieter Verfaillie 2012-12-03 21:34:00 UTC 
tests/doctool/Makefile.am does some creative things, patches will be attached shortly
Comment 1 Dieter Verfaillie 2012-12-03 21:39:57 UTC 
Created attachment 230592 [details] [review]
tests: fix incremental build
Comment 2 Dieter Verfaillie 2012-12-03 21:40:56 UTC 
Created attachment 230593 [details] [review]
tests: don't fake Automake silent mode
Comment 3 Dieter Verfaillie 2012-12-03 21:41:16 UTC 
Created attachment 230594 [details] [review]
tests: ignore errors returned by rm -f
Comment 4 Colin Walters 2012-12-03 21:46:18 UTC 
Review of attachment 230592 [details] [review]:

Sure.
Comment 5 Colin Walters 2012-12-03 21:48:20 UTC 
Review of attachment 230593 [details] [review]:

Didn't know about AM_V_at; looks handy.
Comment 6 Colin Walters 2012-12-03 21:48:50 UTC 
Review of attachment 230594 [details] [review]:

Hrm?  Doesn't rm -f already ignore errors?
Comment 7 Dieter Verfaillie 2012-12-03 21:51:45 UTC 
(In reply to comment #6)
> Review of attachment 230594 [details] [review]:
> 
> Hrm?  Doesn't rm -f already ignore errors?

On the top of my head, one reason it can and will return an
error is "Access denied" errors due to the file being open in
some other program (virus scanners and the like) when built
on windows (using MSYS to run the GNU build system parts).
Comment 8 Dieter Verfaillie 2012-12-03 22:15:30 UTC 
Comment on attachment 230594 [details] [review]
tests: ignore errors returned by rm -f

After discussing a bit on irc with Colin, we have agreed not to go with this general fix until such a time it proves necessary.
Comment 9 André Klapper 2015-02-07 16:59:10 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]