After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689472 - autotools: append branch subdir to builddir for non-srcdir modules
autotools: append branch subdir to builddir for non-srcdir modules
Status: RESOLVED OBSOLETE
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-12-02 04:23 UTC by Leo Singer
Modified: 2021-05-17 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.11 KB, patch)
2012-12-02 04:23 UTC, Leo Singer
none Details | Review
updated patch (1.13 KB, patch)
2016-12-14 21:35 UTC, Leo Singer
reviewed Details | Review

Description Leo Singer 2012-12-02 04:23:52 UTC
Created attachment 230430 [details] [review]
proposed patch

For non-srcdir builds of autotools modules, the name of the build directory takes into account the buildroot and the branch's module name, but not the branch's subdir. As a result, multiple autotools modules can be built with the same builddir if their sources are in subdirectories of the same branch.

This patch modifies autotools' get_builddir method to append the branch's subdir, if it has one, when performing a non-srcdir build.

My example of such a source layout is this git repository:
http://www.lsc-group.phys.uwm.edu/cgit/lalsuite/tree/

It contains a number of closely related autotools and distutils projects for analyzing data for the LIGO experiment <http://www.ligo.org/>.
Comment 1 Leo Singer 2012-12-10 19:40:32 UTC
Is there a way to work around this with a builddir_pattern setting in my jhbuildrc file?
Comment 2 Leo Singer 2016-12-14 21:35:53 UTC
Created attachment 341973 [details] [review]
updated patch

I am attaching an updated and rebased patch that corrects an issue with tarball sources, which do not have subdir attributes.
Comment 3 Michael Catanzaro 2017-01-16 15:36:12 UTC
Review of attachment 341973 [details] [review]:

I tested this but it doesn't seem to work? At least when I 'git checkout gnome-3-22' and 'jhbuild buildone -n epiphany' all the build files are still generated in ~/.cache/jhbuild/build/epiphany, not in any subdir. :/
Comment 4 Leo Singer 2017-01-16 18:30:12 UTC
That is as expected because epiphany is in its own git repository (https://git.gnome.org/browse/epiphany/tree/). This patch will only affect git repositories that contain multiple autotools projects in individual subdirectories (e.g. https://versions.ligo.org/cgit/lalsuite/tree/).
Comment 5 GNOME Infrastructure Team 2021-05-17 15:55:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/jhbuild/-/issues/155.