After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689456 - build: Use -Bsymbolic-functions by default if available
build: Use -Bsymbolic-functions by default if available
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-01 19:51 UTC by Colin Walters
Modified: 2015-02-07 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Use -Bsymbolic-functions by default if available (2.46 KB, patch)
2012-12-01 19:51 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-12-01 19:51:15 UTC 
While we have much larger performance problems right now, using
-Bsymbolic-functions to avoid internal PLT indirection is an easy win.

This is the same code that both GLib and GTK+ have.
Comment 1 Colin Walters 2012-12-01 19:51:18 UTC 
Created attachment 230407 [details] [review]
build: Use -Bsymbolic-functions by default if available
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-05 18:53:27 UTC 
Review of attachment 230407 [details] [review]:

Why not just "-Bsymbolic", to make it work for all symbols?
Comment 3 Colin Walters 2012-12-05 18:57:54 UTC 
(In reply to comment #2)
> Review of attachment 230407 [details] [review]:
> 
> Why not just "-Bsymbolic", to make it work for all symbols?

Well, it doesn't matter for g-i because we don't have any global variables.  As I understand it though, it was not a compatible change for GLib to use -Bsymbolic because then GLib itself would see a different copy of global variables as compared to the application.

See e.g. http://www.openwall.com/lists/musl/2012/08/18/8

It's more valuable to match the rest of the stack (currently, glib, pango, gtk+) than it is to be theoretically better here.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-05 18:59:52 UTC 
Review of attachment 230407 [details] [review]:

OK then.
Comment 5 Colin Walters 2012-12-05 19:06:41 UTC 
Attachment 230407 [details] pushed as 68a4a3e - build: Use -Bsymbolic-functions by default if available
Comment 6 André Klapper 2015-02-07 16:48:49 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]