After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689407 - Remove undo-actions-limit key
Remove undo-actions-limit key
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-01 06:23 UTC by Ma Hsiao-chun
Modified: 2013-11-04 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove deprecated setting undo-actions-limit (2.69 KB, patch)
2013-11-04 17:37 UTC, Sébastien Wilmet 		accepted-commit_now Details | Review

Description Ma Hsiao-chun 2012-12-01 06:23:44 UTC 
Hint:
http://git.gnome.org/browse/gedit/tree/data/org.gnome.gedit.gschema.xml.in.in#n58

Since it is in deprecated state for quite a long time, I don't think we need to keep it forever.
Comment 1 Adam Dingle 2013-08-10 00:57:25 UTC 
If we remove the key, what will the undo limit be?  25 (the current default), or -1 (meaning unlimited undo)?
Comment 2 Ma Hsiao-chun 2013-08-10 04:05:09 UTC 
There is also a key called "max-undo-actions" ...
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-08-10 08:26:49 UTC 
afaik that setting is not used anymore but the max-undo-actions one?
Comment 4 Adam Dingle 2013-08-10 12:28:38 UTC 
Ah, I see - when I wrote my comment above I didn't realize there was a second key max-undo-actions.  It appears that undo-actions-limit is unused in the code.  I think we should certainly remove it now.
Comment 5 Sébastien Wilmet 2013-11-04 17:37:22 UTC 
Created attachment 258943 [details] [review]
Remove deprecated setting undo-actions-limit

Deprecated since 2.12. Use max-undo-actions instead.
Comment 6 Paolo Borelli 2013-11-04 17:51:11 UTC 
Review of attachment 258943 [details] [review]:

sure, I have no idea why it was still there
Comment 7 Sébastien Wilmet 2013-11-04 18:29:57 UTC 
Commit pushed. It would have been a good candidate for the gnome-love flag but… too late. It will be for the next easy bug that I find.