After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689392 - swipe-action: Introduce new ::swipe signal
swipe-action: Introduce new ::swipe signal
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
: 689313 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-30 23:22 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-18 02:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
swipe-action: Introduce new ::swipe signal (3.98 KB, patch)
2012-11-30 23:22 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
swipe-action: Introduce new ::swipe signal (4.53 KB, patch)
2012-12-02 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-11-30 23:22:30 UTC 
As suggested by the Emmanueles on IRC.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-11-30 23:22:31 UTC 
Created attachment 230357 [details] [review]
swipe-action: Introduce new ::swipe signal

This deprecates the old ::swept signal, which didn't have a
handled boolean parameter.
Comment 2 Emmanuele Bassi (:ebassi) 2012-12-01 10:24:15 UTC 
Review of attachment 230357 [details] [review]:

::: clutter/clutter-swipe-action.c
@@ +191,3 @@
    * attached actor.
    *
+   * Deprecated: 1.14: Use the ::swipe signal instead.

you also need to add G_SIGNAL_DEPRECATED to the signal flags, so that connecting to the signal (while using G_ENABLE_DIAGNOSTIC) will raise a warning.

@@ +215,3 @@
+   * attached actor.
+   *
+   * Return value: %TRUE if the pan should continue, and %FALSE if

typo: swipe.

::: clutter/clutter-swipe-action.h
@@ +90,2 @@
   /*< private >*/
   void (* _clutter_swipe_action1) (void);

you need to remove a padding slot to preserve ABI.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:50:10 UTC 
Created attachment 230462 [details] [review]
swipe-action: Introduce new ::swipe signal

This deprecates the old ::swept signal, which didn't have a
handled boolean parameter.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-03 01:17:43 UTC 
Attachment 230462 [details] pushed as 184b8c6 - swipe-action: Introduce new ::swipe signal
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-03 01:45:36 UTC 
gah, pushed accidentally. reverted.
Comment 6 Emmanuele Bassi (:ebassi) 2012-12-18 00:39:53 UTC 
Review of attachment 230462 [details] [review]:

looks good.
Comment 7 Emmanuele Bassi (:ebassi) 2012-12-18 00:40:42 UTC 
*** Bug 689313 has been marked as a duplicate of this bug. ***
Comment 8 Emmanuele Bassi (:ebassi) 2012-12-18 02:10:35 UTC 
pushed to master, along with the ClutterSwipeActionClass.swipe member docs, given that gtk-doc complained during distcheck.