After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689300 - Add a org.gnome.Shell.Mode D-Bus property
Add a org.gnome.Shell.Mode D-Bus property
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 685744
 
 
Reported: 2012-11-29 18:17 UTC by Debarshi Ray
Modified: 2012-11-30 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Add a read-only ShellMode property (988 bytes, patch)
2012-11-29 18:18 UTC, Debarshi Ray 		reviewed Details | Review
dbus: Add a read-only org.gnome.Shell.Mode property (1.03 KB, patch)
2012-11-30 11:05 UTC, Debarshi Ray 		none Details | Review
dbus: Add a read-only org.gnome.Shell.Mode property (1.23 KB, patch)
2012-11-30 16:27 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-11-29 18:17:12 UTC 
Knowing the global.session_mode would be useful for gnome-tweak-tool to figure out which schema to tweak for the button-layout key -- the one for the vanilla shell or the one for the default-minimize extension for the classic mode.
Comment 1 Debarshi Ray 2012-11-29 18:18:23 UTC 
Created attachment 230219 [details] [review]
dbus: Add a read-only ShellMode property
Comment 2 Florian Müllner 2012-11-29 18:27:19 UTC 
Review of attachment 230219 [details] [review]:

Why not SessionMode? I really dislike the duplication in 'org.gnome.Shell.ShellFoo' (if you prefer 'org.gnome.Shell.Mode' to match the command line parameter, I'd be fine with that as well)
Comment 3 Debarshi Ray 2012-11-29 20:00:06 UTC 
I prefer Mode myself, but then I saw ShellVersion and assumed that it is some kind of convention. I'll change it to org.gnome.Shell.Mode.
Comment 4 Debarshi Ray 2012-11-30 11:05:33 UTC 
Created attachment 230268 [details] [review]
dbus: Add a read-only org.gnome.Shell.Mode property
Comment 5 Debarshi Ray 2012-11-30 16:27:18 UTC 
Created attachment 230299 [details] [review]
dbus: Add a read-only org.gnome.Shell.Mode property

dbus: Add a read-only org.gnome.Shell.Mode property

This is meant to expose the global.session_mode to applications such
as the gnome-tweak-tool, which would need it to differentiate between
the vanilla GNOME Shell mode and the fallback replacement mode.
Comment 6 Debarshi Ray 2012-11-30 16:27:45 UTC 
From #gnome-shell on irc.gnome.org:
<fmuellner> sure