After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689297 - Power menu - not enough padding between discharge time and percentage
Power menu - not enough padding between discharge time and percentage
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-29 17:56 UTC by Allan Day
Modified: 2013-01-08 22:30 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
PowerMenu: increase padding to the left of the percentage (2.08 KB, patch)
2012-11-30 17:12 UTC, Giovanni Campagna
committed Details | Review

Description Allan Day 2012-11-29 17:56:30 UTC
See the screenshot:

http://bugzilla-attachments.gnome.org/attachment.cgi?id=229478

"remaining" and "14%" are so close that they virtually run into each other. It would look better and be easier to read if they were kept further apart.
Comment 1 Giovanni Campagna 2012-11-30 15:21:10 UTC
I see roughly 1em of space there, which should be enough to separate the information.
So, how much padding do you expect there? 24px / 2em? More?

Consider also this varies with language, i.e. in italian the menu is larger because of the longer settings panel name.
Comment 2 Allan Day 2012-11-30 15:29:40 UTC
Looking at the mockups, 24px seems about right.

One thing to note - it would be good if the menu didn't change width when the percentage goes from single/double/triple digits. (Don't know whether it does that currently or not.)
Comment 3 Giovanni Campagna 2012-11-30 15:43:13 UTC
It changes width, yes.
And I had in mind a static 24px padding on the percentage.
Doing something fancier to keep the menu stable and keep it as a proper padding (instead of aligning to the right of the longest string in the menu) would be more work.
Comment 4 Allan Day 2012-11-30 15:45:55 UTC
We can make stable width a separate issue. No need to let it block on this.
Comment 5 Giovanni Campagna 2012-11-30 17:12:24 UTC
Created attachment 230308 [details] [review]
PowerMenu: increase padding to the left of the percentage

This avoids having the percentage and device label in close succession.
Comment 6 Giovanni Campagna 2013-01-08 22:13:46 UTC
So?
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-01-08 22:24:41 UTC
Review of attachment 230308 [details] [review]:

OK.
Comment 8 Giovanni Campagna 2013-01-08 22:30:51 UTC
Attachment 230308 [details] pushed as 65723bc - PowerMenu: increase padding to the left of the percentage