After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689295 - broken hot plug and multi-action notifications
broken hot plug and multi-action notifications
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-29 17:42 UTC by Allan Day
Modified: 2012-11-30 17:43 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
Fix notification height expansion (3.46 KB, patch)
2012-11-30 15:07 UTC, Giovanni Campagna 		committed Details | Review

Description Allan Day 2012-11-29 17:42:06 UTC 
This recently appeared in master - hot plug notifications and the libnotify test-multiple-actions test don't get displayed properly. You see the top half of a close button peeping up from the bottom of the screen, and that's it.
Comment 1 Giovanni Campagna 2012-11-30 15:07:44 UTC 
Created attachment 230285 [details] [review]
Fix notification height expansion

MessageTray._tween removes all tweens now, so it removes also
those setting the height to expanded for critical notifications.

This is a regression from 1a27d7dfc02c06bd0ccf4258a9108207b8832ce4
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-30 17:21:51 UTC 
Review of attachment 230285 [details] [review]:

Why don't you just rewrite MessageTray at this point...
Comment 3 Giovanni Campagna 2012-11-30 17:41:06 UTC 
(In reply to comment #2)
> Review of attachment 230285 [details] [review]:
> 
> Why don't you just rewrite MessageTray at this point...

I am! It's my evil plan, patch after patch, I'll take over it! :)
Comment 4 Giovanni Campagna 2012-11-30 17:43:33 UTC 
I added the tag to the commit line, so git-bz doesn't recognize it.