After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689284 - memory leaks
memory leaks
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-29 14:32 UTC by Pavel Vasin
Modified: 2012-11-30 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
importer: Fix memory leak (1.13 KB, patch)
2012-11-29 14:33 UTC, Pavel Vasin 		committed Details | Review
importer: Fix GError leaks (1.03 KB, patch)
2012-11-29 14:33 UTC, Pavel Vasin 		committed Details | Review
dbus-exports: Fix memory leak (776 bytes, patch)
2012-11-29 14:33 UTC, Pavel Vasin 		committed Details | Review
arg: Fix mem leak (699 bytes, patch)
2012-11-29 14:34 UTC, Pavel Vasin 		committed Details | Review
dbus-values: Fix mem leak (663 bytes, patch)
2012-11-29 14:34 UTC, Pavel Vasin 		committed Details | Review
arg: Fix uninitialized pointer (952 bytes, patch)
2012-11-29 14:34 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-11-29 14:32:54 UTC 
see patches
Comment 1 Pavel Vasin 2012-11-29 14:33:16 UTC 
Created attachment 230191 [details] [review]
importer: Fix memory leak
Comment 2 Pavel Vasin 2012-11-29 14:33:37 UTC 
Created attachment 230192 [details] [review]
importer: Fix GError leaks
Comment 3 Pavel Vasin 2012-11-29 14:33:54 UTC 
Created attachment 230193 [details] [review]
dbus-exports: Fix memory leak
Comment 4 Pavel Vasin 2012-11-29 14:34:11 UTC 
Created attachment 230194 [details] [review]
arg: Fix mem leak
Comment 5 Pavel Vasin 2012-11-29 14:34:34 UTC 
Created attachment 230195 [details] [review]
dbus-values: Fix mem leak
Comment 6 Pavel Vasin 2012-11-29 14:34:53 UTC 
Created attachment 230196 [details] [review]
arg: Fix uninitialized pointer
Comment 7 Colin Walters 2012-11-29 20:16:00 UTC 
Review of attachment 230191 [details] [review]:

Yep, thanks!
Comment 8 Colin Walters 2012-11-29 20:16:57 UTC 
Review of attachment 230192 [details] [review]:

Looks right.
Comment 9 Colin Walters 2012-11-29 20:21:55 UTC 
Review of attachment 230193 [details] [review]:

Hm, yes.
Comment 10 Colin Walters 2012-11-29 20:23:29 UTC 
Review of attachment 230194 [details] [review]:

Ok.
Comment 11 Colin Walters 2012-11-29 20:24:16 UTC 
Review of attachment 230195 [details] [review]:

Looks correct.
Comment 12 Colin Walters 2012-11-29 20:25:21 UTC 
Review of attachment 230196 [details] [review]:

Oops!  This one was my fault.  Thanks for the fix!
Comment 13 Colin Walters 2012-11-30 13:07:05 UTC 
Attachment 230191 [details] pushed as 32da445 - importer: Fix memory leak
Attachment 230192 [details] pushed as 213644a - importer: Fix GError leaks
Attachment 230193 [details] pushed as eec5665 - dbus-exports: Fix memory leak
Attachment 230194 [details] pushed as 70ada17 - arg: Fix mem leak
Attachment 230195 [details] pushed as c17d2b5 - dbus-values: Fix mem leak
Attachment 230196 [details] pushed as c2c9229 - arg: Fix uninitialized pointer