After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689259 - gnutls: Fix regression where begin_handshake() is not called
gnutls: Fix regression where begin_handshake() is not called
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-11-29 09:58 UTC by Stef Walter
Modified: 2012-11-29 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnutls: Fix regression where begin_handshake() is not called (3.91 KB, patch)
2012-11-29 09:58 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-11-29 09:58:10 UTC 
Seems like somewhere along the line the GTlsConnectionGnutls
begin_handsake() virtual method is not being called anymore.

This has various side-effects, such as servers not enforcing
authentication-mode.
Comment 1 Stef Walter 2012-11-29 09:58:13 UTC 
Created attachment 230161 [details] [review]
gnutls: Fix regression where begin_handshake() is not called

The begin_handshake() virtual method is no longer called. This results
in stuff like the GTlsServerConnection authentication-mode not being
passed to gnutls.

Fix issue, and add tests which a future regression in this area
should fall over.
Comment 2 Stef Walter 2012-11-29 22:02:55 UTC 
Attachment 230161 [details] pushed as eb2029d - gnutls: Fix regression where begin_handshake() is not called