GNOME Bugzilla – Bug 689252
Use nice Unicode for date formatting for sunrise/sunset times
Last modified: 2013-03-02 14:28:49 UTC
Created attachment 230153 [details] [review] patch The ratio character is nicer aligned for this use than the stock colon, and a thin space is all that is needed before am/pm. I've just got the ratio character added to Cantarell - you can see a before/after comparison of the lock screen clock in the cantarell bug 689184 Note that the patch probably has some python2 assumptions in it - I'm not a native Python speaker, and just googled for how to work around ascii assumptions in strftime
Thanks! I think we can simply use the utf-8 string without encoding the characters: source files show be marked to be in utf-8 and pygobject should be smart enough to allow this, I just quickly tested the following >>> from gi.repository import Gtk >>> l = Gtk.Label("€€€€") >>> w = Gtk.Window() >>> w.add(l) >>> w.show() >>> w.show_all() >>> Gtk.main() I also think we use the column in a few more places (e.g. the stopwatch laps)
(In reply to comment #1) > Thanks! > > I think we can simply use the utf-8 string without encoding the characters: > source files show be marked to be in utf-8 and pygobject should be smart enough > to allow this, I just quickly tested the following sure, if that works, that's much better. > I also think we use the column in a few more places (e.g. the stopwatch laps) Yeah, I only did the clock and alarm part - I don't know if the ratio will make any difference in the split string situations in the other tabs. In any case, may want to hold off on applying this until we have a cantarell release which includes the ratio glyph.
I am waiting for the py3 port before tackling this so that we do not need to rework twice how utf8 strings are handled
clocks is now fixed, except from the sunrise/sunset labels that come directly from libgweather. I am reassigning this bug accordingly.
And now libgweather is fixed too.