GNOME Bugzilla – Bug 689249
Fade scroll view fade edges near scrolling edges
Last modified: 2012-11-29 21:27:11 UTC
Right now, scroll view fades pop into existence, which gives for a very jarring effect. Fade the fades out when approaching the edge while scrolling, rather than having the fades suddenly appear on edges. ... Feel free to make a better description. I'm so confused right now; the word fade does not mean anything to me anymore. Fade fade fade fade fade fade fade. Nope.
Created attachment 230140 [details] [review] scroll-view-sizing: Add a lot more boxes
Created attachment 230141 [details] [review] scroll-view-sizing: Enable vfade by default
Created attachment 230142 [details] [review] scroll-view-fade: Put the shader in another file This doesn't make any changes to the shader outside of adding a header; it simply makes changes in the future easier to edit.
Created attachment 230143 [details] [review] scroll-view-fade: Clean up GLSL Basic cleanup of what we're doing already. This moves a bunch of the "inside the fade area" checks to the top, before doing any calculations.
Created attachment 230144 [details] [review] scroll-view-fade: Use GLSL 1.20 GLSL 1.20 is a better language, and we'll rely on it in future updates. This doesn't have any additional constraints, since GLSL 1.20 was standardized before GLSL-supporting drivers came out.
Created attachment 230145 [details] [review] scroll-view-fade: Do the offset math in the shader This doesn't (or shouldn't) change the visual appearance of the fade effect, but does do all the testing math inside the shader, rather than on the CPU. This will make fading the offset much easier in the future.
Created attachment 230146 [details] [review] scroll-view-fade: Only calculate the ratios if they're needed This prevents some calculations being done for poor drivers with bad optimizers.
Created attachment 230147 [details] [review] scroll-view-fade: Fade gradients when near edges Rather than sharply transitioning to gradients, fade them out when near the edge of the scroll view.
Review of attachment 230140 [details] [review]: OK.
Review of attachment 230141 [details] [review]: OK.
Review of attachment 230142 [details] [review]: This is indeed way better to work with.
Review of attachment 230143 [details] [review]: OK.
Review of attachment 230144 [details] [review]: OK.
Review of attachment 230145 [details] [review]: Looks correct couldn't spot any visual differences either.
Review of attachment 230146 [details] [review]: OK.
Review of attachment 230147 [details] [review]: OK.
Attachment 230140 [details] pushed as affcd5c - scroll-view-sizing: Add a lot more boxes Attachment 230141 [details] pushed as 7c93639 - scroll-view-sizing: Enable vfade by default Attachment 230142 [details] pushed as b3fea01 - scroll-view-fade: Put the shader in another file Attachment 230143 [details] pushed as ae1a3a0 - scroll-view-fade: Clean up GLSL Attachment 230144 [details] pushed as c84236e - scroll-view-fade: Use GLSL 1.20 Attachment 230145 [details] pushed as 5c439f4 - scroll-view-fade: Do the offset math in the shader Attachment 230146 [details] pushed as 69347ff - scroll-view-fade: Only calculate the ratios if they're needed Attachment 230147 [details] pushed as b4f5f1e - scroll-view-fade: Fade gradients when near edges
*** Bug 661506 has been marked as a duplicate of this bug. ***