After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689221 - Fix express installation against Fedora 18
Fix express installation against Fedora 18
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
3.6.x
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-28 14:43 UTC by Zeeshan Ali
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fedora,express: Don't ask for '@base' package group (793 bytes, patch)
2012-11-28 14:43 UTC, Zeeshan Ali
committed Details | Review
Revert "fedora,express: Don't ask for '@base' package group" (743 bytes, patch)
2013-01-10 21:27 UTC, Zeeshan Ali
committed Details | Review
fedora,express: Port script for Fedora 18 (3.01 KB, patch)
2013-01-10 21:27 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2012-11-28 14:43:55 UTC
See patch
Comment 1 Zeeshan Ali 2012-11-28 14:43:57 UTC
Created attachment 230091 [details] [review]
fedora,express: Don't ask for '@base' package group

Apparently '@base' package group does not exist anymore in Fedora 18.
Since we don't need to specify this package group explicitly for older
Fedora either, we can simply drop it from the list.

This fixes express installation against Fedora 18.
Comment 2 Christophe Fergeau 2012-12-07 09:12:23 UTC
ACK assuming this does not cause regression with older Fedoras
Comment 3 Zeeshan Ali 2012-12-07 20:38:50 UTC
(In reply to comment #2)
> ACK assuming this does not cause regression with older Fedoras

Thanks for looking into it. Though its now obsolete with bug#676537 fixed. For the record, I fixed this in libosnfo at the same time.
Comment 4 Zeeshan Ali 2013-01-10 14:30:05 UTC
Actually we need this for 3.6: https://bugzilla.redhat.com/show_bug.cgi?id=893897
Comment 5 Zeeshan Ali 2013-01-10 21:27:29 UTC
Created attachment 233180 [details] [review]
Revert "fedora,express: Don't ask for '@base' package group"

Turns out this doesn't exactly fix latest the install against the latest
ISO. Will commit a better solution that works.

This reverts commit 40dc19c9bc5b6d45a4668b1c61af5dca7fb99423.
Comment 6 Zeeshan Ali 2013-01-10 21:27:32 UTC
Created attachment 233181 [details] [review]
fedora,express: Port script for Fedora 18

Package groups have changed in Fedora 18. This patch makes the script
work against Fedora 18 without breaking it against older releases.
Comment 7 Alexander Larsson 2013-01-10 21:36:31 UTC
Review of attachment 233180 [details] [review]:

ack
Comment 8 Alexander Larsson 2013-01-10 21:37:28 UTC
Review of attachment 233181 [details] [review]:

ack
Comment 9 Zeeshan Ali 2013-01-10 21:54:53 UTC
Attachment 233180 [details] pushed as 4f1a167 - Revert "fedora,express: Don't ask for '@base' package group"
Attachment 233181 [details] pushed as 88bad82 - fedora,express: Port script for Fedora 18