After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689165 - eog contains files which do not have a valid copyright or license information
eog contains files which do not have a valid copyright or license information
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal major
: GNOME3.8
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-27 14:30 UTC by Richard Hughes
Modified: 2012-12-30 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Richard Hughes 2012-11-27 14:30:27 UTC
As part of a internal licence audit thing we have to do for RHEL at Red Hat we've been looking at the sources in all the stuff we ship for possible problems.

A few possible problems were found in eog by Bastien, and I've been confirming them today. The issues are these are all missing licensing information in the file header:

* jpegutils/jpegint-8a.h
* jpegutils/jpegint.h
* jpegutils/transupp-8a.[c|h]
* jpegutils/transupp.h

The files transupp-6b.c and transupp-6b.h contain a header from GThumb, but that's okay as the header says GPLv2+. We're not actually compiling jpeg v8 stuff, so that's not a huge concern at the moment.

Also, some of the plugin files (that we are using) are missing copyright and licensing information, e.g.:

* plugins/reload/eog-reload-plugin.[c|h]
* plugins/fullscreen/eog-fullscreen-plugin.[c|h]

If you could just clarify the licences of these files and perhaps instate some copyright info in them I'd be very grateful. Thanks.

Richard.
Comment 1 Felix Riemann 2012-11-27 18:42:56 UTC
(In reply to comment #0)
> As part of a internal licence audit thing we have to do for RHEL at Red Hat
> we've been looking at the sources in all the stuff we ship for possible
> problems.
> 
> A few possible problems were found in eog by Bastien, and I've been confirming
> them today. The issues are these are all missing licensing information in the
> file header:
> 
> * jpegutils/jpegint-8a.h
> * jpegutils/jpegint.h
> * jpegutils/transupp-8a.[c|h]
> * jpegutils/transupp.h
> 
> The files transupp-6b.c and transupp-6b.h contain a header from GThumb, but
> that's okay as the header says GPLv2+. We're not actually compiling jpeg v8
> stuff, so that's not a huge concern at the moment.

So far I can only see missing licenses in jpegint.h and transupp.h.
The others do carry a license header (GThumb + libjpeg). These files are slightly modified versions of the ones shipped with libjpeg.
Besides that the README.[6b|8a] files also contain the license text.

Will check what's appropriate for the two missing headers though.

> Also, some of the plugin files (that we are using) are missing copyright and
> licensing information, e.g.:
> 
> * plugins/reload/eog-reload-plugin.[c|h]
> * plugins/fullscreen/eog-fullscreen-plugin.[c|h]
> 
> If you could just clarify the licences of these files and perhaps instate some
> copyright info in them I'd be very grateful. Thanks.

These are likely GPL2+ as the statusbar-date plugin.
CCing Lucas (being the original author) to be sure.
Comment 2 Felix Riemann 2012-12-30 17:38:27 UTC
Fixed in the plugins by assuming them to be in line with Lucas'
other contributions at that time.

commit e19320330bf805e0e0b336363d70499d02b85e82
Author: Felix Riemann <>
Date:   Sun Dec 30 18:08:59 2012 +0100

    reload: Add missing license headers
    
    Assuming that the plugins are in line with Lucas' other contributions
    and thus are licensed as GPLv2+.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=689165

commit 967c22f5c0b3d1e6b90058666d8cae23d77fb03a
Author: Felix Riemann <>
Date:   Sun Dec 30 17:48:02 2012 +0100

    fullscreen: Add missing license headers
    
    Assuming that the plugins are in line with Lucas' other contributions
    and thus are licensed as GPLv2+.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=689165

commit 6de1a4cabed6ef2adf86b1cdde1ee9ccf2b9b671
Author: Felix Riemann <>
Date:   Sun Dec 30 17:42:21 2012 +0100

    jpegutils: Add missing license headers
    
    transupp.h is based on the file shipped by gThumb.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=689165
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.