After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689117 - Drop calls to g_thread_init() in tests
Drop calls to g_thread_init() in tests
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.8
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
: 689105 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-26 20:35 UTC by Allison Karlitskaya (desrt)
Modified: 2013-01-01 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop calls to g_thread_init() in tests (2.48 KB, patch)
2012-11-26 20:35 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2012-11-26 20:35:10 UTC
See patch.
Comment 1 Allison Karlitskaya (desrt) 2012-11-26 20:35:11 UTC
Created attachment 229946 [details] [review]
Drop calls to g_thread_init() in tests

Our dependency on Gtk 3.4 already gives us an indirect dependency on a
GLib that no longer requires these calls.

We got away with this for a while due to gstreamer's public dependency
on libgthread, but as of bug 689043 gstreamer no longer does this so we
now get link errors.
Comment 2 David King 2012-11-26 20:56:48 UTC
*** Bug 689105 has been marked as a duplicate of this bug. ***
Comment 3 David King 2012-11-26 20:57:18 UTC
Review of attachment 229946 [details] [review]:

Thanks Ryan, please push.
Comment 4 Allison Karlitskaya (desrt) 2012-11-28 04:48:33 UTC
Attachment 229946 [details] pushed as 8ee8540 - Drop calls to g_thread_init() in tests
Comment 5 Stefan Skoglund 2013-01-01 20:40:41 UTC
This should (?) also be pushed to the 3.6 branch (i'm trying to build the 3.6 branch with jhbuild.)

jhbuild  moduleset 3.6 selects the 3.6 branch of cheese but gstreamers's master.