After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689091 - The Desktop < > Overview transition could use some tweaking.
The Desktop < > Overview transition could use some tweaking.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-26 16:21 UTC by Reda Lazri
Modified: 2013-01-18 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Demo (835.58 KB, video/webm)
2012-11-26 16:21 UTC, Reda Lazri
  Details
MessageTray: wait until the tray is hidden to switch styles (2.41 KB, patch)
2012-11-26 16:55 UTC, Giovanni Campagna
none Details | Review
MessageTray: wait until the tray is hidden to switch styles (2.41 KB, patch)
2012-11-26 16:59 UTC, Giovanni Campagna
committed Details | Review

Description Reda Lazri 2012-11-26 16:21:07 UTC
Created attachment 229913 [details]
Demo

This is about the 'message-tray' component, as selected.

If you open the Overview and close it again, you'll notice the background-color + noise bg appear for a fraction of a second. Something that needs a cleanup.

As far as my understanding goes, it's trying to show the gray bg and nicely hide it which creates a slightly bad effect in the process.

I think the gray bg belongs to the desktop, when showing the overview it should not try to display it at all and the same thing can be said when coming back to the desktop, it should just close it while keeping the 'in-overview' styles without bothering with the 'background-image' from the desktop.
Comment 1 Giovanni Campagna 2012-11-26 16:55:19 UTC
Created attachment 229917 [details] [review]
MessageTray: wait until the tray is hidden to switch styles

Switching style on Overview::hiding creates a weird effect, as the noise
texture is shown while the overview is still visibile. Instead, wait for
the tray to be fully hidden, then apply the new style.
As now the switch is invisible, there is no need for the transition
(which introduced the same problem on overview showing)
Comment 2 Giovanni Campagna 2012-11-26 16:59:27 UTC
Created attachment 229918 [details] [review]
MessageTray: wait until the tray is hidden to switch styles

Switching style on Overview::hiding creates a weird effect, as the noise
texture is shown while the overview is still visibile. Instead, wait for
the tray to be fully hidden, then apply the new style.
As now the switch is invisible, there is no need for the transition
(which introduced the same problem on overview showing)
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-11-26 17:04:57 UTC
Review of attachment 229918 [details] [review]:

::: data/theme/gnome-shell.css
@@ -1265,3 @@
     background: #2e3436 url(message-tray-background.png);
     background-repeat: repeat;
-    transition-duration: 250;

This is there intentionally: open the message tray, then hit the hot corner.
Comment 4 Giovanni Campagna 2012-11-26 17:06:35 UTC
Uhm, I thought of that, but IMHO if you hit the hot corner, you're so overwhelmed by the desktop clone transition combined with the window moving in place that you probably don't notice it.
Comment 5 Allan Day 2012-11-26 17:22:13 UTC
This bug will hopefully be obsoleted by bug 687787.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-01-18 19:20:28 UTC
Review of attachment 229918 [details] [review]:

After trying it out, yeah, it's not that important.
Comment 7 Giovanni Campagna 2013-01-18 20:08:14 UTC
Attachment 229918 [details] pushed as df2cab8 - MessageTray: wait until the tray is hidden to switch styles