GNOME Bugzilla – Bug 689062
Remove custom overview swipe scrolling code
Last modified: 2012-11-30 23:04:20 UTC
Nowadays, Clutter has all the API we need to do nifty swipe scrolling. This also makes the experience smoother for the app/search lists, rather than bouncing back to arbitrary pages when releasing the pointer, and also adds kinetic scrolling.
Created attachment 229876 [details] [review] viewSelector: Set the active page immediately This prevents some focus management issues.
Created attachment 229877 [details] [review] searchDisplay, appDisplay: Use ClutterPanAction for re-swipe scrolling The sooner we can kill off the custom overview swipe scroll code, the better.
Created attachment 229878 [details] [review] workspacesView: Clean up scroll code a bit There's no code path that results in us not animating.
Created attachment 229879 [details] [review] workspacesView: Don't use the overview swipe scrolling system Switch to a ClutterPanAction instead too.
Created attachment 229880 [details] [review] overview: Remove custom swipe scrolling implementation
Review of attachment 229876 [details] [review]: Which issues specifically does this fix? ::: js/ui/viewSelector.js @@ +215,1 @@ Tweener.addTween(this._activePage, Change this._activePage -> oldPage here too (so we don't miss it if some day we move around the oldPage/this._activePage assignments)
Review of attachment 229877 [details] [review]: ::: js/ui/searchDisplay.js @@ +216,3 @@ + _onPan: function(action) { + let [dx, dy] = action.get_motion_delta(0); + let adjustment = this.actor.vscroll.adjustment; Don't you need the scrollView's adjustment here? this.actor is a StBoxLayout.
Review of attachment 229878 [details] [review]: Looks good.
Review of attachment 229879 [details] [review]: ::: js/ui/workspacesView.js @@ +454,3 @@ + Main.overview.addAction(action); + this.actor.connect('notify::mapped', Lang.bind(this, function() { + })); Can you use g_object_bind_property()?
Review of attachment 229880 [details] [review]: Looks good to me.
(In reply to comment #6) > Review of attachment 229876 [details] [review]: > > Which issues specifically does this fix? Hmm, I tried to reproduce it and the issue is now gone. Let's drop this patch for now.
Created attachment 230252 [details] [review] workspacesView: Don't use the overview swipe scrolling system Switch to a ClutterPanAction instead too.
Created attachment 230253 [details] [review] searchDisplay, appDisplay: Use ClutterPanAction for re-swipe scrolling The sooner we can kill off the custom overview swipe scroll code, the better.
Review of attachment 230252 [details] [review]: This looks fine to me now.
Review of attachment 230253 [details] [review]: ++
Attachment 229878 [details] pushed as 57d9e7d - workspacesView: Clean up scroll code a bit Attachment 229880 [details] pushed as 98f4b99 - overview: Remove custom swipe scrolling implementation Attachment 230252 [details] pushed as 830e701 - workspacesView: Don't use the overview swipe scrolling system Attachment 230253 [details] pushed as 5fc16bb - searchDisplay, appDisplay: Use ClutterPanAction for re-swipe scrolling