After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689049 - privacy: Add recent-files related settings
privacy: Add recent-files related settings
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 689050
 
 
Reported: 2012-11-25 20:50 UTC by Matthias Clasen
Modified: 2012-12-03 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
privacy: Add recent-files related settings (1.42 KB, patch)
2012-11-25 20:50 UTC, Matthias Clasen 		needs-work Details | Review
privacy: Add recent-files related settings (1.42 KB, patch)
2012-11-27 23:15 UTC, Matthias Clasen 		reviewed Details | Review
privacy: Add recent-files related settings (1.49 KB, patch)
2012-11-30 17:19 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-11-25 20:50:16 UTC 
These settings are needed to implement the privacy panel
design.
Comment 1 Matthias Clasen 2012-11-25 20:50:18 UTC 
Created attachment 229839 [details] [review]
privacy: Add recent-files related settings
Comment 2 Bastien Nocera 2012-11-27 09:17:12 UTC 
Review of attachment 229839 [details] [review]:

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +29,3 @@
+      <default>true</default>
+      <_summary>Whether to remember recently used files</_summary>
+      <_description>If FALSE, applications will not remember recently

Why "keep"?

remember-recent-files.

@@ +32,3 @@
+        used files.</_description>
+    </key>
+    <key name="retain-recent-files-for" type="i">

recent-files-max-age?
Comment 3 Matthias Clasen 2012-11-27 23:15:39 UTC 
Created attachment 230051 [details] [review]
privacy: Add recent-files related settings

These settings are needed to implement the privacy panel
design.
Comment 4 Bastien Nocera 2012-11-29 15:21:41 UTC 
Review of attachment 230051 [details] [review]:

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +36,3 @@
+      <_summary>Number of days to remember recently used files for</_summary>
+      <_description>Recently used files will be remembered for this many days.
+        Set to -1 to retain unlimited history.</_description>

How would "max-age" == 0 behave? The same as "remember-recent-files" = FALSE?
Comment 5 Bastien Nocera 2012-11-29 15:22:31 UTC 
Review of attachment 230051 [details] [review]:

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +36,3 @@
+      <_summary>Number of days to remember recently used files for</_summary>
+      <_description>Recently used files will be remembered for this many days.
+        Set to -1 to retain unlimited history.</_description>

I would rather have max-age be a uint, and have "0" be "unlimited".
Comment 6 Matthias Clasen 2012-11-30 02:27:39 UTC 
That means you have to do nontrivial translation gsetting -> xsetting in gsd.
We can certainly do that. The current definition is lifted straight out of GtkSettings:gtk-recent-files-max-age
Comment 7 Bastien Nocera 2012-11-30 06:44:10 UTC 
GtkSettings:gtk-recent-files-max-age has the behaviour of "0" documented. Make sure it's also in the schemas definition.
Comment 8 Matthias Clasen 2012-11-30 17:19:06 UTC 
Created attachment 230310 [details] [review]
privacy: Add recent-files related settings

These settings are needed to implement the privacy panel
design.
Comment 9 Matthias Clasen 2012-11-30 17:19:29 UTC 
Expanded the documentation to be in sync with whats documented in gtk
Comment 10 Bastien Nocera 2012-12-03 09:28:07 UTC 
Attachment 230310 [details] pushed as 252bce0 - privacy: Add recent-files related settings