After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689048 - privacy: Add trash and temp files related settings
privacy: Add trash and temp files related settings
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 149572 687774
 
 
Reported: 2012-11-25 20:49 UTC by Matthias Clasen
Modified: 2012-12-03 05:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
privacy: Add trash and temp files related settings (1.72 KB, patch)
2012-11-25 20:49 UTC, Matthias Clasen
needs-work Details | Review
privacy: Add trash and temp files related settings (1.79 KB, patch)
2012-11-27 13:28 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2012-11-25 20:49:39 UTC
These settings are needed to implement the privacy panel
design.
Comment 1 Matthias Clasen 2012-11-25 20:49:40 UTC
Created attachment 229838 [details] [review]
privacy: Add trash and temp files related settings
Comment 2 Bastien Nocera 2012-11-27 09:07:41 UTC
Review of attachment 229838 [details] [review]:

::: schemas/org.gnome.desktop.privacy.gschema.xml.in.in
@@ +10,3 @@
+    <key name="purge-trash" type="b">
+      <default>true</default>
+      <_summary>Whether to remote trashed files automatically</_summary>

remove.

@@ +12,3 @@
+      <_summary>Whether to remote trashed files automatically</_summary>
+      <_description>If TRUE, automatically remove files from the trash
+        after 'purge-after' days.</_description>

This isn't clear. Does it clear the whole trash:/// contents every X days? Or does it remove trash files older than a certain age?

I'm guessing the latter, so I would call it "remove-old-trash-files".

@@ +18,3 @@
+      <_summary>Whether to remove temporary files automatically</_summary>
+      <_description>If TRUE, automatically remove temporary files
+        after 'purge-after' days.</_description>

Same problem.

@@ +24,3 @@
+      <_summary>Number of days to keep trash and temporary files</_summary>
+      <_description>Temporary and trash files will be cleaned up after
+        this many days.</_description>

I'd call it "old-files-age"

"Consider trash and temporary files to be old after this many days."
Comment 3 Matthias Clasen 2012-11-27 13:28:48 UTC
Created attachment 229998 [details] [review]
privacy: Add trash and temp files related settings
Comment 4 Bastien Nocera 2012-11-27 13:39:24 UTC
Attachment 229998 [details] pushed as e16fdd4 - privacy: Add trash and temp files related settings